Re: [PATCH 1/2] misc: ezport-firmware: new driver

Greg Kroah-Hartman
2018-03-23T13:17:12Z

On Tue, Mar 20, 2018 at 06:22:00PM +0100, Sebastian Reichel wrote:
> General Electric Healthcare's PPD has a secondary processor from
> NXP's Kinetis K20 series. It's firmware can be updated from Linux
> using the EzPort interface. This driver implements the firmware
> updating process.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> ---
> Documentation/devicetree/bindings/misc/ge-achc.txt | 19 +-

Bindings should be in a separate patch, right?

> +static int ezport_read_data(struct spi_device *spi, u32 address,
> + u8 *buffer, size_t size)
> +{
> + struct spi_transfer xfers[2] = {};

You can send SPI data from the stack?

> + u8 *query = kmalloc(EZPORT_FAST_READ_SIZE, GFP_KERNEL);
> + int ret;
> +
> + if (!query)
> + return -ENOMEM;
> +
> + query[0] = EZPORT_CMD_FAST_READ;
> + query[1] = address >> 16;
> + query[2] = address >> 8;
> + query[3] = address >> 0;
> + query[4] = EZPORT_DUMMY;
> +
> + xfers[0].len = EZPORT_FAST_READ_SIZE;
> + xfers[0].tx_buf = query;
> +
> + xfers[1].len = size;
> + xfers[1].rx_buf = buffer;
> +
> + ret = spi_sync_transfer(spi, xfers, 2);
> +
> + kfree(query);
> +
> + return ret;
> +}
> +static DEVICE_ATTR_WO(update_fw);
> +static DEVICE_ATTR_RO(verify_fw);

New sysfs attributes need Documentation/ABI updates please.

Also please fix up the kbuild-reported build errors.

thanks,

greg k-h