From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752638AbeCWNw3 (ORCPT ); Fri, 23 Mar 2018 09:52:29 -0400 Received: from mx2.suse.de ([195.135.220.15]:33288 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752447AbeCWNw2 (ORCPT ); Fri, 23 Mar 2018 09:52:28 -0400 Date: Fri, 23 Mar 2018 14:52:25 +0100 From: Michal Hocko To: Steven Rostedt Cc: LKML , linux-mm@kvack.org, Mel Gorman , Vlastimil Babka , Andrew Morton , Linus Torvalds , Alexei Starovoitov Subject: Re: [PATCH] mm, vmscan, tracing: Use pointer to reclaim_stat struct in trace event Message-ID: <20180323135225.GV23100@dhcp22.suse.cz> References: <20180322121003.4177af15@gandalf.local.home> <20180323134200.GT23100@dhcp22.suse.cz> <20180323094753.760b2c86@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180323094753.760b2c86@gandalf.local.home> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 23-03-18 09:47:53, Steven Rostedt wrote: > On Fri, 23 Mar 2018 14:42:00 +0100 > Michal Hocko wrote: > > > Yes, the number of parameter is large. struct reclaim_stat is an > > internal stuff so I didn't want to export it. I do not have strong > > objections to add it somewhere tracing can find it though. > > The one solution is to pull the tracing file > include/trace/events/vmscan.h into mm/ and have a local header to store > the reclaim_stat structure that both vmscan.h and vmscan.c can > reference. I guess we can live with the public definition as well. -- Michal Hocko SUSE Labs