From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Peter Rosin <peda@axentia.se>
Cc: <linux-kernel@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"David S. Miller" <davem@davemloft.net>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
<linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 0/3] iio: add unit converter
Date: Fri, 23 Mar 2018 13:14:01 +0000 [thread overview]
Message-ID: <20180323141401.000031cc@huawei.com> (raw)
In-Reply-To: <20180319170246.26830-1-peda@axentia.se>
On Mon, 19 Mar 2018 18:02:43 +0100
Peter Rosin <peda@axentia.se> wrote:
> Hi!
>
> This moves the iio-mux driver to a new category, since I think
> it will be the single driver in that category forever, and now
> I'm adding a new driver that is somewhat similar in nature...
>
> But that rename is not very interesting, it's just reshuffling.
> It's the new driver that I need. Specifically, I need to allow
> linear scaling and modification of the type of an io-channel.
> I don't know exactly how that is accomplished in the best way,
> but this is what I came up with.
>
> The use cases are an ADC hooked up to measure a "big" voltage by
> looking at the midpoint of a voltage divider, and an ADC used
> to measure the current by looking at the voltage over a resistor.
>
> Comments?
It is pretty much how I would have implemented it as well.
Will probably do a detailed review over the weekend.
Not convinced entirely on the 'wrapper' naming though.
Will think about it...
Jonathan
>
> Cheers,
> Peter
>
> Peter Rosin (3):
> iio: rename the multiplexer category to wrapper
> dt-bindings: iio: wrapper: add io-channel-unit-converter
> iio: wrapper: unit-converter: new driver
>
> .../{multiplexer => wrapper}/io-channel-mux.txt | 0
> .../iio/wrapper/io-channel-unit-converter.txt | 84 +++++++
> MAINTAINERS | 11 +-
> drivers/iio/Kconfig | 2 +-
> drivers/iio/Makefile | 2 +-
> drivers/iio/multiplexer/Makefile | 6 -
> drivers/iio/{multiplexer => wrapper}/Kconfig | 13 +-
> drivers/iio/wrapper/Makefile | 7 +
> drivers/iio/{multiplexer => wrapper}/iio-mux.c | 0
> drivers/iio/wrapper/iio-unit-converter.c | 268 +++++++++++++++++++++
> 10 files changed, 381 insertions(+), 12 deletions(-)
> rename Documentation/devicetree/bindings/iio/{multiplexer => wrapper}/io-channel-mux.txt (100%)
> create mode 100644 Documentation/devicetree/bindings/iio/wrapper/io-channel-unit-converter.txt
> delete mode 100644 drivers/iio/multiplexer/Makefile
> rename drivers/iio/{multiplexer => wrapper}/Kconfig (53%)
> create mode 100644 drivers/iio/wrapper/Makefile
> rename drivers/iio/{multiplexer => wrapper}/iio-mux.c (100%)
> create mode 100644 drivers/iio/wrapper/iio-unit-converter.c
>
next prev parent reply other threads:[~2018-03-23 13:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 17:02 [PATCH 0/3] iio: add unit converter Peter Rosin
2018-03-19 17:02 ` [PATCH 1/3] iio: rename the multiplexer category to wrapper Peter Rosin
2018-03-19 18:36 ` Randy Dunlap
2018-03-19 17:02 ` [PATCH 2/3] dt-bindings: iio: wrapper: add io-channel-unit-converter Peter Rosin
2018-03-24 13:53 ` Jonathan Cameron
2018-03-24 14:06 ` Jonathan Cameron
2018-03-26 22:23 ` Rob Herring
2018-03-27 8:01 ` Peter Rosin
2018-03-28 2:29 ` Phil Reid
2018-03-29 13:55 ` Rob Herring
2018-03-30 22:38 ` Peter Rosin
2018-03-19 17:02 ` [PATCH 3/3] iio: wrapper: unit-converter: new driver Peter Rosin
2018-03-24 14:03 ` Jonathan Cameron
2018-03-27 7:42 ` Peter Rosin
2018-03-27 13:22 ` Jonathan Cameron
2018-03-27 13:32 ` Peter Rosin
2018-03-30 9:24 ` Jonathan Cameron
2018-03-23 13:14 ` Jonathan Cameron [this message]
2018-03-23 13:59 ` [PATCH 0/3] iio: add unit converter Peter Rosin
2018-03-24 13:48 ` Jonathan Cameron
2018-03-24 16:34 ` Linus Walleij
2018-03-24 17:47 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180323141401.000031cc@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=peda@axentia.se \
--cc=pmeerw@pmeerw.net \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox