From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752331AbeCWQKA (ORCPT ); Fri, 23 Mar 2018 12:10:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34232 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752169AbeCWQJ7 (ORCPT ); Fri, 23 Mar 2018 12:09:59 -0400 Date: Fri, 23 Mar 2018 17:09:57 +0100 From: Greg KH To: Ioana Ciornei Cc: Laurentiu Tudor , "linux-kernel@vger.kernel.org" , "stuyoder@gmail.com" , Ruxandra Ioana Ciocoi Radulescu , "arnd@arndb.de" , Razvan Stefanescu , Roy Pledge Subject: Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support Message-ID: <20180323160957.GA3113@kroah.com> References: <20180323154654.GA382@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 23, 2018 at 03:56:24PM +0000, Ioana Ciornei wrote: > > > > > On Fri, Mar 23, 2018 at 10:38:56AM -0500, Ioana Ciornei wrote: > > > +#include "fsl-mc-private.h" > > > + > > > +#define FSL_MC_BUS_MAX_MINORS 1 > > > > As you only need/want one character device here, why not just use the misc > > device api? It's much simpler, and handles all of the housekeeping for you > > correctly. It also means I don't have to audit all of your chardev code to verify it > > is correct :) > > I have considered the misc device api but the fsl-mc bus, since it is > a platform driver, is probing before the misc char driver. How? The misc code is just "core code" there's nothing to "probe" here. Is this an init-call ordering issue somehow? A platform driver probe should be after the misc core is initialized. And if not, you can always defer your probe. thanks, greg k-h