Re: [PATCH v3 1/2] x86, msr: allow rdmsr_safe_on_cpu() to schedule

Ingo Molnar
2018-03-27T09:36:54Z

* Thomas Gleixner <tglx@linutronix.de> wrote:

> On Mon, 26 Mar 2018, Eric Dumazet wrote:
> > On Sun, Mar 25, 2018 at 11:40 PM Ingo Molnar <mingo@kernel.org> wrote:
> > > If performance matters then the relevant MSR events should be added and
> > > gsysd
> > > should be updated to support MSR events.
> > >
> >
> > Thanks for the hints Ingo. I have forwarded them.
> >
> > I am pretty sure gsysd was designed and written years before perf even
> > existed,
> > so I am not sure all this will ever be implemented.
> >
> > I guess I will apply the kernel patches locally for the time being.
>
> I'm still considering to merge them because there is no real reason not to
> do so. The interfaces exist and are used. Reducing their impact is
> certainly worthwhile.

Ok, that's a good point, and the patches themselves are sane:

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

Ingo