From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752975AbeCXUDL (ORCPT ); Sat, 24 Mar 2018 16:03:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:36792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752947AbeCXUDJ (ORCPT ); Sat, 24 Mar 2018 16:03:09 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB7B32183B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Adrian Hunter , Andi Kleen , David Ahern , Jin Yao , Jiri Olsa , Namhyung Kim , Wang Nan Subject: [PATCH 04/44] perf annotate tui: Use annotate_browser__cycles_width() mroe Date: Sat, 24 Mar 2018 17:01:31 -0300 Message-Id: <20180324200211.21326-5-acme@kernel.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180324200211.21326-1-acme@kernel.org> References: <20180324200211.21326-1-acme@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnaldo Carvalho de Melo Instead of an open coded equivalent, will reduce a bit noise in the following patches. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: https://lkml.kernel.org/n/tip-pnwn1dg9345zawhgiorpsadf@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui/browsers/annotate.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index ca3d99c1e4d9..0f84a52b4088 100644 --- a/tools/perf/ui/browsers/annotate.c +++ b/tools/perf/ui/browsers/annotate.c @@ -308,7 +308,7 @@ static void annotate_browser__draw_current_jump(struct ui_browser *browser) struct map_symbol *ms = ab->b.priv; struct symbol *sym = ms->sym; u8 pcnt_width = annotate_browser__pcnt_width(ab); - int width = 0; + int width; /* PLT symbols contain external offsets */ if (strstr(sym->name, "@plt")) @@ -355,8 +355,7 @@ static void annotate_browser__draw_current_jump(struct ui_browser *browser) to = (u64)btarget->idx; } - if (ab->have_cycles) - width = ANNOTATION__IPC_WIDTH + ANNOTATION__CYCLES_WIDTH; + width = annotate_browser__cycles_width(ab); ui_browser__set_color(browser, HE_COLORSET_JUMP_ARROWS); __ui_browser__line_arrow(browser, -- 2.14.3