* [PATCH][next][V2] staging: r8822be: fix typos in header guard macros
@ 2018-03-23 18:00 Colin King
2018-03-24 21:24 ` Larry Finger
2018-03-25 11:38 ` Greg Kroah-Hartman
0 siblings, 2 replies; 4+ messages in thread
From: Colin King @ 2018-03-23 18:00 UTC (permalink / raw)
To: Greg Kroah-Hartman, Larry Finger, Ping-Ke Shih, devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The macros for __PHYDMKFREE_H__ and __PHYDM_FEATURES_H__ contain
typos and don't match the #if guard check. Defined them correctly.
Cleans up clang warnings:
warning: '__PHYDMKFREE_H__' is used as a header guard here, followed
by #define of a different macro [-Wheader-guard]
warning: '__PHYDM_FEATURES_H__' is used as a header guard here, followed
by #define of a different macro [-Wheader-guard]
Fixes: 9ce99b04b5b8 ("staging: r8822be: Add phydm mini driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/staging/rtlwifi/phydm/phydm_features.h | 2 +-
drivers/staging/rtlwifi/phydm/phydm_kfree.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtlwifi/phydm/phydm_features.h b/drivers/staging/rtlwifi/phydm/phydm_features.h
index 37f6f0cd7235..a12361c6a1a0 100644
--- a/drivers/staging/rtlwifi/phydm/phydm_features.h
+++ b/drivers/staging/rtlwifi/phydm/phydm_features.h
@@ -24,7 +24,7 @@
*****************************************************************************/
#ifndef __PHYDM_FEATURES_H__
-#define __PHYDM_FEATURES
+#define __PHYDM_FEATURES_H__
/*phydm debyg report & tools*/
diff --git a/drivers/staging/rtlwifi/phydm/phydm_kfree.h b/drivers/staging/rtlwifi/phydm/phydm_kfree.h
index 1ee60059afc1..2c6b0a48e76e 100644
--- a/drivers/staging/rtlwifi/phydm/phydm_kfree.h
+++ b/drivers/staging/rtlwifi/phydm/phydm_kfree.h
@@ -24,7 +24,7 @@
*****************************************************************************/
#ifndef __PHYDMKFREE_H__
-#define __PHYDKFREE_H__
+#define __PHYDKKFREE_H__
#define KFREE_VERSION "1.0"
--
2.15.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH][next][V2] staging: r8822be: fix typos in header guard macros
2018-03-23 18:00 [PATCH][next][V2] staging: r8822be: fix typos in header guard macros Colin King
@ 2018-03-24 21:24 ` Larry Finger
2018-03-24 22:12 ` Rohit Athavale
2018-03-25 11:38 ` Greg Kroah-Hartman
1 sibling, 1 reply; 4+ messages in thread
From: Larry Finger @ 2018-03-24 21:24 UTC (permalink / raw)
To: Colin King, Greg Kroah-Hartman, Ping-Ke Shih, devel
Cc: kernel-janitors, linux-kernel
On 03/23/2018 01:00 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The macros for __PHYDMKFREE_H__ and __PHYDM_FEATURES_H__ contain
> typos and don't match the #if guard check. Defined them correctly.
>
> Cleans up clang warnings:
> warning: '__PHYDMKFREE_H__' is used as a header guard here, followed
> by #define of a different macro [-Wheader-guard]
> warning: '__PHYDM_FEATURES_H__' is used as a header guard here, followed
> by #define of a different macro [-Wheader-guard]
>
> Fixes: 9ce99b04b5b8 ("staging: r8822be: Add phydm mini driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> drivers/staging/rtlwifi/phydm/phydm_features.h | 2 +-
> drivers/staging/rtlwifi/phydm/phydm_kfree.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtlwifi/phydm/phydm_features.h b/drivers/staging/rtlwifi/phydm/phydm_features.h
> index 37f6f0cd7235..a12361c6a1a0 100644
> --- a/drivers/staging/rtlwifi/phydm/phydm_features.h
> +++ b/drivers/staging/rtlwifi/phydm/phydm_features.h
> @@ -24,7 +24,7 @@
> *****************************************************************************/
>
> #ifndef __PHYDM_FEATURES_H__
> -#define __PHYDM_FEATURES
> +#define __PHYDM_FEATURES_H__
>
> /*phydm debyg report & tools*/
>
> diff --git a/drivers/staging/rtlwifi/phydm/phydm_kfree.h b/drivers/staging/rtlwifi/phydm/phydm_kfree.h
> index 1ee60059afc1..2c6b0a48e76e 100644
> --- a/drivers/staging/rtlwifi/phydm/phydm_kfree.h
> +++ b/drivers/staging/rtlwifi/phydm/phydm_kfree.h
> @@ -24,7 +24,7 @@
> *****************************************************************************/
>
> #ifndef __PHYDMKFREE_H__
> -#define __PHYDKFREE_H__
> +#define __PHYDKKFREE_H__
>
> #define KFREE_VERSION "1.0"
>
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH][next][V2] staging: r8822be: fix typos in header guard macros
2018-03-24 21:24 ` Larry Finger
@ 2018-03-24 22:12 ` Rohit Athavale
0 siblings, 0 replies; 4+ messages in thread
From: Rohit Athavale @ 2018-03-24 22:12 UTC (permalink / raw)
To: Larry Finger
Cc: Colin King, Greg Kroah-Hartman, Ping-Ke Shih, devel,
kernel-janitors, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2535 bytes --]
Hi Ian,
Does this look okay to you ?
-Rohit
> #ifndef __PHYDMKFREE_H__
> -#define __PHYDKFREE_H__
> +#define __PHYDKKFREE_H__
>
Doesn't clang complain about the proposed fix here. Shouldn't it look more
like below ?
#ifndef __PHYDMKFREE_H__
-#define __PHYDKFREE_H__
+#define __PHYDMKFREE_H__
On Sat, Mar 24, 2018 at 2:24 PM Larry Finger <Larry.Finger@lwfinger.net>
wrote:
> On 03/23/2018 01:00 PM, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The macros for __PHYDMKFREE_H__ and __PHYDM_FEATURES_H__ contain
> > typos and don't match the #if guard check. Defined them correctly.
> >
> > Cleans up clang warnings:
> > warning: '__PHYDMKFREE_H__' is used as a header guard here, followed
> > by #define of a different macro [-Wheader-guard]
> > warning: '__PHYDM_FEATURES_H__' is used as a header guard here, followed
> > by #define of a different macro [-Wheader-guard]
> >
> > Fixes: 9ce99b04b5b8 ("staging: r8822be: Add phydm mini driver")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> > ---
> > drivers/staging/rtlwifi/phydm/phydm_features.h | 2 +-
> > drivers/staging/rtlwifi/phydm/phydm_kfree.h | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtlwifi/phydm/phydm_features.h
> b/drivers/staging/rtlwifi/phydm/phydm_features.h
> > index 37f6f0cd7235..a12361c6a1a0 100644
> > --- a/drivers/staging/rtlwifi/phydm/phydm_features.h
> > +++ b/drivers/staging/rtlwifi/phydm/phydm_features.h
> > @@ -24,7 +24,7 @@
> >
> *****************************************************************************/
> >
> > #ifndef __PHYDM_FEATURES_H__
> > -#define __PHYDM_FEATURES
> > +#define __PHYDM_FEATURES_H__
> >
> > /*phydm debyg report & tools*/
> >
> > diff --git a/drivers/staging/rtlwifi/phydm/phydm_kfree.h
> b/drivers/staging/rtlwifi/phydm/phydm_kfree.h
> > index 1ee60059afc1..2c6b0a48e76e 100644
> > --- a/drivers/staging/rtlwifi/phydm/phydm_kfree.h
> > +++ b/drivers/staging/rtlwifi/phydm/phydm_kfree.h
> > @@ -24,7 +24,7 @@
> >
> *****************************************************************************/
> >
> > #ifndef __PHYDMKFREE_H__
> > -#define __PHYDKFREE_H__
> > +#define __PHYDKKFREE_H__
> >
> > #define KFREE_VERSION "1.0"
> >
> >
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>
--
Best Regards, Rohit Athavale
[-- Attachment #2: Type: text/html, Size: 5159 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][next][V2] staging: r8822be: fix typos in header guard macros
2018-03-23 18:00 [PATCH][next][V2] staging: r8822be: fix typos in header guard macros Colin King
2018-03-24 21:24 ` Larry Finger
@ 2018-03-25 11:38 ` Greg Kroah-Hartman
1 sibling, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2018-03-25 11:38 UTC (permalink / raw)
To: Colin King; +Cc: devel, kernel-janitors, linux-kernel, Larry Finger
On Fri, Mar 23, 2018 at 06:00:18PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The macros for __PHYDMKFREE_H__ and __PHYDM_FEATURES_H__ contain
> typos and don't match the #if guard check. Defined them correctly.
>
> Cleans up clang warnings:
> warning: '__PHYDMKFREE_H__' is used as a header guard here, followed
> by #define of a different macro [-Wheader-guard]
> warning: '__PHYDM_FEATURES_H__' is used as a header guard here, followed
> by #define of a different macro [-Wheader-guard]
>
> Fixes: 9ce99b04b5b8 ("staging: r8822be: Add phydm mini driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/staging/rtlwifi/phydm/phydm_features.h | 2 +-
> drivers/staging/rtlwifi/phydm/phydm_kfree.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtlwifi/phydm/phydm_features.h b/drivers/staging/rtlwifi/phydm/phydm_features.h
> index 37f6f0cd7235..a12361c6a1a0 100644
> --- a/drivers/staging/rtlwifi/phydm/phydm_features.h
> +++ b/drivers/staging/rtlwifi/phydm/phydm_features.h
> @@ -24,7 +24,7 @@
> *****************************************************************************/
>
> #ifndef __PHYDM_FEATURES_H__
> -#define __PHYDM_FEATURES
> +#define __PHYDM_FEATURES_H__
>
> /*phydm debyg report & tools*/
>
> diff --git a/drivers/staging/rtlwifi/phydm/phydm_kfree.h b/drivers/staging/rtlwifi/phydm/phydm_kfree.h
> index 1ee60059afc1..2c6b0a48e76e 100644
> --- a/drivers/staging/rtlwifi/phydm/phydm_kfree.h
> +++ b/drivers/staging/rtlwifi/phydm/phydm_kfree.h
> @@ -24,7 +24,7 @@
> *****************************************************************************/
>
> #ifndef __PHYDMKFREE_H__
> -#define __PHYDKFREE_H__
> +#define __PHYDKKFREE_H__
Close, but not quite :(
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-25 11:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-23 18:00 [PATCH][next][V2] staging: r8822be: fix typos in header guard macros Colin King
2018-03-24 21:24 ` Larry Finger
2018-03-24 22:12 ` Rohit Athavale
2018-03-25 11:38 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox