From: Stefan Agner <stefan@agner.ch>
To: linux@armlinux.org.uk, ard.biesheuvel@linaro.org, arnd@arndb.de
Cc: robin.murphy@arm.com, nicolas.pitre@linaro.org,
marc.zyngier@arm.com, behanw@converseincode.com,
keescook@chromium.org, Bernhard.Rosenkranzer@linaro.org,
mka@chromium.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Stefan Agner <stefan@agner.ch>
Subject: [PATCH v2 6/6] ARM: uaccess: remove const to avoid duplicate specifier
Date: Sun, 25 Mar 2018 20:09:59 +0200 [thread overview]
Message-ID: <20180325180959.28008-7-stefan@agner.ch> (raw)
In-Reply-To: <20180325180959.28008-1-stefan@agner.ch>
Some users of get_user use the macro with an argument p which
is already specified as static. When using clang this leads to
a duplicate specifier:
CC arch/arm/kernel/process.o
In file included from init/do_mounts.c:15:
In file included from ./include/linux/tty.h:7:
In file included from ./include/uapi/linux/termios.h:6:
In file included from ./arch/arm/include/generated/uapi/asm/termios.h:1:
./include/asm-generic/termios.h:25:6: warning: duplicate 'const' declaration
specifier [-Wduplicate-decl-specifier]
if (get_user(tmp, &termio->c_iflag) < 0)
^
./arch/arm/include/asm/uaccess.h:195:3: note: expanded from macro 'get_user'
__get_user_check(x, p); \
^
./arch/arm/include/asm/uaccess.h:155:12: note: expanded from macro
'__get_user_check'
register const typeof(*(p)) __user *__p asm("r0") = (p);\
Remove the const attribute from the register declaration
to avoid the duplicate const specifier. In a test with ptrace.c
and traps.c (both using get_user with non-const arguments for p)
the generated code was exactly the same.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
Similar issue has already been discussed here:
https://patchwork.kernel.org/patch/9693821/
arch/arm/include/asm/uaccess.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/uaccess.h b/arch/arm/include/asm/uaccess.h
index 0bf2347495f1..3d614e90c19f 100644
--- a/arch/arm/include/asm/uaccess.h
+++ b/arch/arm/include/asm/uaccess.h
@@ -152,7 +152,7 @@ extern int __get_user_64t_4(void *);
#define __get_user_check(x, p) \
({ \
unsigned long __limit = current_thread_info()->addr_limit - 1; \
- register const typeof(*(p)) __user *__p asm("r0") = (p);\
+ register typeof(*(p)) __user *__p asm("r0") = (p); \
register typeof(x) __r2 asm("r2"); \
register unsigned long __l asm("r1") = __limit; \
register int __e asm("r0"); \
--
2.16.2
next prev parent reply other threads:[~2018-03-25 18:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-25 18:09 [PATCH v2 0/6] ARM: clang support Stefan Agner
2018-03-25 18:09 ` [PATCH v2 1/6] bus: arm-cci: use asm unreachable Stefan Agner
2018-03-25 18:14 ` Nicolas Pitre
2018-03-25 18:19 ` Stefan Agner
2018-04-16 15:59 ` Stefan Agner
2018-03-25 18:09 ` [PATCH v2 2/6] efi/libstub/arm: add support for building with clang Stefan Agner
2018-03-25 18:09 ` [PATCH v2 3/6] ARM: trusted_foundations: do not use naked function Stefan Agner
2018-03-26 21:20 ` Dmitry Osipenko
2018-03-27 11:54 ` Robin Murphy
2018-03-27 12:16 ` Dmitry Osipenko
2018-04-16 15:56 ` Stefan Agner
2018-04-16 16:08 ` Stephen Warren
2018-04-16 18:21 ` Stefan Agner
2018-04-17 8:11 ` Thierry Reding
2018-06-26 8:11 ` Stefan Agner
2018-07-12 22:43 ` Kees Cook
2018-07-12 23:01 ` Russell King - ARM Linux
2018-07-13 8:07 ` Stefan Agner
2018-05-19 22:02 ` Dmitry Osipenko
2018-07-12 22:59 ` Russell King - ARM Linux
2018-03-25 18:09 ` [PATCH v2 4/6] ARM: drop no-thumb-interwork in EABI mode Stefan Agner
2018-06-12 17:19 ` [v2,4/6] " Guenter Roeck
2018-06-12 17:27 ` Stefan Agner
2018-03-25 18:09 ` [PATCH v2 5/6] ARM: add support for building ARM kernel with clang Stefan Agner
2018-03-25 18:09 ` Stefan Agner [this message]
2018-05-07 20:24 ` [PATCH v2 0/6] ARM: clang support Stefan Agner
2018-05-07 21:09 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180325180959.28008-7-stefan@agner.ch \
--to=stefan@agner.ch \
--cc=Bernhard.Rosenkranzer@linaro.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=behanw@converseincode.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=mka@chromium.org \
--cc=nicolas.pitre@linaro.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox