From: Andi Kleen <ak@linux.intel.com>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, kan.liang@intel.com,
yao.jin@intel.com
Subject: Re: [PATCH v1 0/3] Support perf -vv
Date: Mon, 26 Mar 2018 02:00:31 -0700 [thread overview]
Message-ID: <20180326090031.GN13724@tassilo.jf.intel.com> (raw)
In-Reply-To: <1522080424-12912-1-git-send-email-yao.jin@linux.intel.com>
On Tue, Mar 27, 2018 at 12:07:01AM +0800, Jin Yao wrote:
> We keep having bug reports that when users build perf on their own,
> but they don't install some needed libraries such as libelf,
> libbfd/libibery.
>
> The perf can build, but it is missing important functionality. And
> users may complain that perf has issue or bug.
>
> This patch-set support 'perf -vv' which will print the compiled-in
> status of libraries. Once users think perf missing some functionality,
> it should be very easy for them to check the libraries status.
I don't think this solves the problem. How should the user know
that they need to run perf -vv. Also normal users don't know
that libelf is needed for symbols for example.
We need a warning that is visible together with the symbols
and that clearly describes the problem.
-Andi
>
> For example:
>
> $ ./perf -vv
> perf version 4.13.rc5.g9b7a81b
> dwarf: [ on ]
> dwarf_getlocations: [ on ]
> glibc: [ on ]
> gtk2: [ on ]
> libaudit: [ off ]
> libbfd: [ on ]
> libelf: [ on ]
> libnuma: [ on ]
> numa_num_possible_cpus: [ on ]
> libperl: [ on ]
> libpython: [ on ]
> libslang: [ on ]
> libcrypto: [ on ]
> libunwind: [ on ]
> libdw-dwarf-unwind: [ on ]
> zlib: [ on ]
> lzma: [ on ]
> get_cpuid: [ on ]
> bpf: [ on ]
>
> Jin Yao (3):
> perf config: Add -DNO_GLIBC to CFLAGS
> perf version: Print the status of compiled-in libraries
> perf: Support perf -vv
>
> tools/perf/Makefile.config | 2 +
> tools/perf/builtin-version.c | 125 +++++++++++++++++++++++++++++++++++++++++++
> tools/perf/builtin.h | 1 +
> tools/perf/perf.c | 6 +++
> 4 files changed, 134 insertions(+)
>
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-03-26 9:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 16:07 [PATCH v1 0/3] Support perf -vv Jin Yao
2018-03-26 9:00 ` Andi Kleen [this message]
2018-03-26 9:07 ` Jiri Olsa
2018-03-26 13:06 ` Jin, Yao
2018-03-26 16:07 ` [PATCH v1 1/3] perf config: Add -DNO_GLIBC to CFLAGS Jin Yao
2018-03-26 16:07 ` [PATCH v1 2/3] perf version: Print the status of compiled-in libraries Jin Yao
2018-03-26 9:39 ` Jiri Olsa
2018-03-26 13:51 ` Jin, Yao
2018-03-27 3:04 ` Jin, Yao
2018-03-27 12:38 ` Jiri Olsa
2018-03-27 13:26 ` Jin, Yao
2018-03-27 1:44 ` Jin, Yao
2018-03-27 12:56 ` Jiri Olsa
2018-03-27 13:17 ` Jin, Yao
2018-03-27 13:35 ` Jiri Olsa
2018-03-27 5:58 ` Ingo Molnar
2018-03-27 6:04 ` Jin, Yao
2018-03-26 16:07 ` [PATCH v1 3/3] perf: Support perf -vv Jin Yao
2018-03-27 6:03 ` Ingo Molnar
2018-03-27 6:12 ` Jin, Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180326090031.GN13724@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox