From: Tejun Heo <tj@kernel.org>
To: yuankuiz@codeaurora.org
Cc: cgroups@vger.kernel.org, lizefan@huawei.com, hannes@cmpxchg.org,
linux-kernel@vger.kernel.org, pkondeti@codeaurora.org,
cgroups-owner@vger.kernel.org
Subject: Re: [PATCH]cgroup: __cpuset_node_allowed return bool
Date: Mon, 26 Mar 2018 07:12:12 -0700 [thread overview]
Message-ID: <20180326141212.GI2149215@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <0fee75e4a1b12f5fca30e04306a95788@codeaurora.org>
Hello, John.
On Sat, Mar 24, 2018 at 01:05:50PM +0800, yuankuiz@codeaurora.org wrote:
> From 304cec1cc42255fbd9e231a810f4eea20ab74b90 Mon Sep 17 00:00:00 2001
> From: John Zhao <yuankuiz@codeaurora.org>
> Date: Sat, 24 Mar 2018 13:01:32 +0800
> Subject: [PATCH] cgroup: __cpuset_node_allowed return bool
>
> as a bool, __cpuset_node_allowed(...) return should be bool.
So, as a minor cleanup patch, this is fine but can you please soften
the commit title / description a bit? It doesn't have to be bool.
int is fine. bool may be marginally more readable but that's about
it, so let's please make the commit match that.
Thanks.
--
tejun
next prev parent reply other threads:[~2018-03-26 14:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-24 4:56 [PATCH]cgroup: __cpuset_node_allowed return bool yuankuiz
2018-03-24 5:05 ` yuankuiz
2018-03-26 14:12 ` Tejun Heo [this message]
2018-03-26 14:20 ` yuankuiz
2018-03-26 14:25 ` Tejun Heo
2018-03-26 14:37 ` yuankuiz
2018-03-26 14:41 ` yuankuiz
2018-03-27 16:45 ` yuankuiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180326141212.GI2149215@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=cgroups-owner@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=pkondeti@codeaurora.org \
--cc=yuankuiz@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox