From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 2/2] KVM: VMX: Add Force Emulation Prefix for "emulate the next instruction"
Date: Tue, 27 Mar 2018 01:18:40 -0400 [thread overview]
Message-ID: <20180327051840.GF16974@char.us.oracle.com> (raw)
In-Reply-To: <CANRm+Cw7VVNmA=DvrzbUDoTQZ_O2sTQVJiu-v-fVt+e3jfB_gw@mail.gmail.com>
On Tue, Mar 27, 2018 at 01:03:15PM +0800, Wanpeng Li wrote:
> 2018-03-27 12:55 GMT+08:00 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>:
> > On Tue, Mar 27, 2018 at 12:40:20AM -0400, Konrad Rzeszutek Wilk wrote:
> >> On Mon, Mar 26, 2018 at 07:12:15PM -0700, Wanpeng Li wrote:
> >> > From: Wanpeng Li <wanpengli@tencent.com>
> >> >
> >> > This patch introduces a Force Emulation Prefix (ud2a; .ascii "kvm") for
> >> > "emulate the next instruction", the codes will be executed by emulator
> >> > instead of processor, for testing purposes.
> >>
> >> Can you expand a bit ? Why do you want this in KVM in the first place?
>
> Please refer to the original discussion(Force Emulation Prefix part).
> https://lkml.org/lkml/2018/3/22/220
That really should be part massaged in this patch as part of the description.
>
> >> Should this be controlled by a boolean parameter?
> >
> > .. per guest. That is instead of a global one, have a per guest one?
>
> As Paolo pointed out offline:
> > Testing without the hacks being done by emulator.flat (TLB mismatch between instructions and data).
And also this above.
> I think a global module is enough for testing.
If so, perhaps have it wrapped with #ifdef DEBUG?
No need to put code gadgets that won't be utilized 99% of time.
>
> Regards,
> Wanpeng Li
next prev parent reply other threads:[~2018-03-27 5:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 2:12 [PATCH 0/2] KVM: VMX: Add Force Emulation Prefix for "emulate the next instruction" Wanpeng Li
2018-03-27 2:12 ` [PATCH 1/2] KVM: VMX: Introduce handle_ud() Wanpeng Li
2018-03-27 4:38 ` Konrad Rzeszutek Wilk
2018-03-27 2:12 ` [PATCH 2/2] KVM: VMX: Add Force Emulation Prefix for "emulate the next instruction" Wanpeng Li
2018-03-27 4:40 ` Konrad Rzeszutek Wilk
2018-03-27 4:55 ` Konrad Rzeszutek Wilk
2018-03-27 5:03 ` Wanpeng Li
2018-03-27 5:18 ` Konrad Rzeszutek Wilk [this message]
2018-03-27 7:25 ` Paolo Bonzini
2018-03-27 7:29 ` Wanpeng Li
2018-03-27 5:09 ` Wanpeng Li
-- strict thread matches above, loose matches on Subject: below --
2018-03-27 7:52 Liran Alon
2018-03-27 8:19 ` Paolo Bonzini
2018-03-27 9:09 ` Wanpeng Li
2018-03-27 8:26 Liran Alon
2018-03-27 9:05 ` Nikita Leshenko
2018-03-27 9:15 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327051840.GF16974@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox