From: Andi Kleen <ak@linux.intel.com>
To: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] perf stat: avoid 10ms limit for printing event counts
Date: Tue, 27 Mar 2018 02:06:42 -0700 [thread overview]
Message-ID: <20180327090642.GP13724@tassilo.jf.intel.com> (raw)
In-Reply-To: <8f27e33e-355a-e6f3-30d9-c0fc3ff46c4d@linux.intel.com>
> When running perf stat -I for monitoring e.g. PCIe uncore counters and
> at the same time profiling some I/O workload by perf record e.g. for
> cpu-cycles and context switches, it is then possible to build and
> observe good-enough consolidated CPU/OS/IO(Uncore) performance picture
> for that workload.
At some point I still hope we can make uncore measurements in
perf record work. Kan tried at some point to allow multiple
PMUs in a group, but was not successfull. But perhaps we
can sample them from a software event instead.
>
> The warning on possible runtime overhead is still preserved, however
> it is only visible when specifying -v option.
I would print it unconditionally. Very few people use -v.
BTW better of course would be to occasionally measure the perf stat
cpu time and only print the warning if it's above some percentage
of a CPU. But that would be much more work.
Rest looks ok.
-Andi
next prev parent reply other threads:[~2018-03-27 9:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 8:09 [PATCH v1] perf stat: avoid 10ms limit for printing event counts Alexey Budankov
2018-03-27 9:06 ` Andi Kleen [this message]
2018-03-27 10:55 ` Alexey Budankov
2018-03-27 11:40 ` Alexey Budankov
2018-03-27 11:59 ` Andi Kleen
2018-03-27 16:27 ` Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327090642.GP13724@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox