From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AIpwx497/wFJpKa1MRjCphixSJEcFdZoRAafc0A4plRlg65orBITgp0Kbv4LSjB18B1sbzFharSj ARC-Seal: i=1; a=rsa-sha256; t=1522168528; cv=none; d=google.com; s=arc-20160816; b=MMtYPt+EFxtKn8czVCld1XiDNYldGh9AOZfcCi8d2umT/rjkY3MimlE5S1T3wwTEd2 /yVZjscffjbSXMx93IcSmUVW+4006Esp/Xz7Fwc/P9lQtgA8jG+RbD72uzdJkZekwc2P 0OLR2v2izi/7DdmBc702Wok/p1x/6L8c9x2qqG/y/1G1lTZ937y3PbcQL1YtpjGPeRNX +gp0bUgHj04dJoLrimBkXpBpKW5aIEvI7u1TDHIk2u9vZH3tJcJIqjNUKQTLTBeJfp7z cePKvAtDgKrFKY68BadliSuLZ0QAxX6JHtTX3c1ctOm6XhLA/CPs84iKkabuDGuCWWZe 9jyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=uwW66zh9wIGcJfi7FswM1+A5418716rsdSA8ZqOEP54=; b=sdCkEF/ERl1b3dFv+EapNDCnVn0phO+XLo2LJai0UPDr7Wz2lm0mlWloxAj0dtNhOs G9Kzx17/M6s3Q/YpB3drYBKjV14QU0PMo0G6ikpzlDKajhmTSXIDuQn5PR83lRiIdAgV kz5obAW0uQn5l5wKUS5q9I0SeSIebKCRHNeYuiruHWQt5aQExT724egAHveG6cIfh6Yz i+CqwJpuIyw0AM9utQXtfLNW0yWm8/klXQOPNQJlxsk0A9JKNG7xYNX5KldSJFn6Zjld u8WTXWwQ0PP7aM/jmLRpLFuyCIAQrNVlc+F0J7BvFoT0Zh9c8tFv1RwU6YiSJSwq+WHY K+OA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.61.202 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.61.202 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans de Goede , Tejun Heo Subject: [PATCH 4.14 042/101] libata: Modify quirks for MX100 to limit NCQ_TRIM quirk to MU01 version Date: Tue, 27 Mar 2018 18:27:14 +0200 Message-Id: <20180327162752.605858831@linuxfoundation.org> X-Mailer: git-send-email 2.16.3 In-Reply-To: <20180327162749.993880276@linuxfoundation.org> References: <20180327162749.993880276@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1596108985800843811?= X-GMAIL-MSGID: =?utf-8?q?1596109387084295961?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hans de Goede commit d418ff56b8f2d2b296daafa8da151fe27689b757 upstream. When commit 9c7be59fc519af ("libata: Apply NOLPM quirk to Crucial MX100 512GB SSDs") was added it inherited the ATA_HORKAGE_NO_NCQ_TRIM quirk from the existing "Crucial_CT*MX100*" entry, but that entry sets model_rev to "MU01", where as the entry adding the NOLPM quirk sets it to NULL. This means that after this commit we no apply the NO_NCQ_TRIM quirk to all "Crucial_CT512MX100*" SSDs even if they have the fixed "MU02" firmware. This commit splits the "Crucial_CT512MX100*" quirk into 2 quirks, one for the "MU01" firmware and one for all other firmware versions, so that we once again only apply the NO_NCQ_TRIM quirk to the "MU01" firmware version. Fixes: 9c7be59fc519af ("libata: Apply NOLPM quirk to ... MX100 512GB SSDs") Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede Signed-off-by: Tejun Heo Signed-off-by: Greg Kroah-Hartman --- drivers/ata/libata-core.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -4523,10 +4523,13 @@ static const struct ata_blacklist_entry /* Crucial BX100 SSD 500GB has broken LPM support */ { "CT500BX100SSD1", NULL, ATA_HORKAGE_NOLPM }, - /* The 512GB version of the MX100 has both queued TRIM and LPM issues */ - { "Crucial_CT512MX100*", NULL, ATA_HORKAGE_NO_NCQ_TRIM | + /* 512GB MX100 with MU01 firmware has both queued TRIM and LPM issues */ + { "Crucial_CT512MX100*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM | ATA_HORKAGE_ZERO_AFTER_TRIM | ATA_HORKAGE_NOLPM, }, + /* 512GB MX100 with newer firmware has only LPM issues */ + { "Crucial_CT512MX100*", NULL, ATA_HORKAGE_ZERO_AFTER_TRIM | + ATA_HORKAGE_NOLPM, }, /* 480GB+ M500 SSDs have both queued TRIM and LPM issues */ { "Crucial_CT480M500*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |