From: Will Deacon <will.deacon@arm.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kbuild@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Ulf Magnusson <ulfalizer@gmail.com>,
Kees Cook <keescook@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
"Luis R . Rodriguez" <mcgrof@kernel.org>,
Nicolas Pitre <nico@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 21/21] arm64: move GCC version check for ARCH_SUPPORTS_INT128 to Kconfig
Date: Tue, 27 Mar 2018 18:28:15 +0100 [thread overview]
Message-ID: <20180327172815.GH18435@arm.com> (raw)
In-Reply-To: <1522128575-5326-22-git-send-email-yamada.masahiro@socionext.com>
On Tue, Mar 27, 2018 at 02:29:35PM +0900, Masahiro Yamada wrote:
> This becomes much neater in Kconfig.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Changes in v2:
> - Newly added
>
> arch/arm64/Kconfig | 1 +
> arch/arm64/Makefile | 2 --
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 7381eeb..0c97f40 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -43,6 +43,7 @@ config ARM64
> select ARCH_USE_QUEUED_RWLOCKS
> select ARCH_SUPPORTS_MEMORY_FAILURE
> select ARCH_SUPPORTS_ATOMIC_RMW
> + select ARCH_SUPPORTS_INT128 if GCC_VERSION >= 50000
> select ARCH_SUPPORTS_NUMA_BALANCING
> select ARCH_WANT_COMPAT_IPC_PARSE_VERSION
> select ARCH_WANT_FRAME_POINTERS
> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index b481b4a..7318165 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -57,8 +57,6 @@ KBUILD_AFLAGS += $(lseinstr) $(brokengasinst)
> KBUILD_CFLAGS += $(call cc-option,-mabi=lp64)
> KBUILD_AFLAGS += $(call cc-option,-mabi=lp64)
>
> -KBUILD_CFLAGS += $(call cc-ifversion, -ge, 0500, -DCONFIG_ARCH_SUPPORTS_INT128)
> -
If this does what it claims to do, then I agree that it's much cleaner!
Acked-by: Will Deacon <will.deacon@arm.com>
Will
next prev parent reply other threads:[~2018-03-27 17:28 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 5:29 [PATCH v2 00/21] kconfig: move compiler capability tests to Kconfig Masahiro Yamada
2018-03-27 5:29 ` [PATCH v2 01/21] kbuild: remove kbuild cache Masahiro Yamada
2018-03-28 3:26 ` Kees Cook
2018-03-27 5:29 ` [PATCH v2 02/21] kbuild: remove CONFIG_CROSS_COMPILE support Masahiro Yamada
2018-03-28 3:28 ` Kees Cook
2018-03-27 5:29 ` [PATCH v2 03/21] kconfig: move and rename sym_expand_string_value() Masahiro Yamada
2018-03-28 3:29 ` Kees Cook
2018-03-27 5:29 ` [PATCH v2 04/21] kconfig: reference environments directly and remove 'option env=' syntax Masahiro Yamada
2018-03-28 3:33 ` Kees Cook
2018-03-29 2:19 ` Ulf Magnusson
2018-03-29 2:56 ` Ulf Magnusson
2018-03-29 17:38 ` Ulf Magnusson
2018-03-30 5:30 ` Masahiro Yamada
2018-04-01 2:27 ` Ulf Magnusson
2018-04-01 2:40 ` Ulf Magnusson
2018-04-13 6:02 ` Masahiro Yamada
2018-03-27 5:29 ` [PATCH v2 05/21] kconfig: remove string expansion in file_lookup() Masahiro Yamada
2018-03-28 3:34 ` Kees Cook
2018-04-01 2:52 ` Ulf Magnusson
2018-03-27 5:29 ` [PATCH v2 06/21] kconfig: remove string expansion for mainmenu after yyparse() Masahiro Yamada
2018-03-28 3:35 ` Kees Cook
2018-04-01 2:59 ` Ulf Magnusson
2018-03-27 5:29 ` [PATCH v2 07/21] kconfig: add function support and implement 'shell' function Masahiro Yamada
2018-03-28 3:41 ` Kees Cook
2018-04-13 5:32 ` Masahiro Yamada
2018-03-29 2:42 ` Ulf Magnusson
2018-04-01 4:19 ` Ulf Magnusson
2018-04-13 5:37 ` Masahiro Yamada
2018-03-27 5:29 ` [PATCH v2 08/21] kconfig: replace $UNAME_RELEASE with function call Masahiro Yamada
2018-03-28 3:42 ` Kees Cook
2018-04-01 4:38 ` Ulf Magnusson
2018-03-27 5:29 ` [PATCH v2 09/21] kconfig: add 'macro' keyword to support user-defined function Masahiro Yamada
2018-03-28 3:45 ` Kees Cook
2018-04-01 6:05 ` Ulf Magnusson
2018-04-01 6:49 ` Ulf Magnusson
2018-04-13 5:44 ` Masahiro Yamada
2018-03-27 5:29 ` [PATCH v2 10/21] kconfig: add 'success' and 'cc-option' macros Masahiro Yamada
2018-03-28 3:46 ` Kees Cook
2018-04-01 6:28 ` Ulf Magnusson
2018-03-27 5:29 ` [PATCH v2 11/21] stack-protector: test compiler capability in Kconfig and drop AUTO mode Masahiro Yamada
2018-03-28 11:18 ` Kees Cook
2018-04-09 8:54 ` Masahiro Yamada
2018-04-09 15:04 ` Kees Cook
2018-04-10 3:15 ` Masahiro Yamada
2018-03-27 5:29 ` [PATCH v2 12/21] kconfig: show compiler version text in the top comment Masahiro Yamada
2018-03-28 3:26 ` Kees Cook
2018-03-27 5:29 ` [PATCH v2 13/21] kconfig: add CC_IS_GCC and GCC_VERSION Masahiro Yamada
2018-03-28 11:19 ` Kees Cook
2018-03-27 5:29 ` [PATCH v2 14/21] kconfig: add CC_IS_CLANG and CLANG_VERSION Masahiro Yamada
2018-03-28 11:22 ` Kees Cook
2018-03-28 11:52 ` Masahiro Yamada
2018-03-27 5:29 ` [PATCH v2 15/21] gcov: remove CONFIG_GCOV_FORMAT_AUTODETECT Masahiro Yamada
2018-03-27 9:12 ` Peter Oberparleiter
2018-03-28 11:24 ` Kees Cook
2018-03-27 5:29 ` [PATCH v2 16/21] kcov: imply GCC_PLUGINS and GCC_PLUGIN_SANCOV instead of select'ing them Masahiro Yamada
2018-03-28 11:25 ` Kees Cook
2018-03-28 11:53 ` Kees Cook
2018-03-27 5:29 ` [PATCH v2 17/21] gcc-plugins: always build plugins with C++ Masahiro Yamada
2018-03-28 11:29 ` Kees Cook
2018-03-27 5:29 ` [PATCH v2 18/21] gcc-plugins: move GCC version check for PowerPC to Kconfig Masahiro Yamada
2018-03-28 11:30 ` Kees Cook
2018-03-27 5:29 ` [PATCH v2 19/21] gcc-plugins: test GCC plugin support in Kconfig Masahiro Yamada
2018-03-28 11:44 ` Kees Cook
2018-04-11 15:55 ` Masahiro Yamada
2018-04-11 16:09 ` Kees Cook
2018-03-27 5:29 ` [PATCH v2 20/21] gcc-plugins: enable GCC_PLUGINS for COMPILE_TEST Masahiro Yamada
2018-03-28 11:47 ` Kees Cook
2018-04-10 6:15 ` Masahiro Yamada
2018-04-10 7:00 ` Kees Cook
2018-03-27 5:29 ` [PATCH v2 21/21] arm64: move GCC version check for ARCH_SUPPORTS_INT128 to Kconfig Masahiro Yamada
2018-03-27 17:28 ` Will Deacon [this message]
2018-03-28 11:55 ` Kees Cook
2018-03-27 16:39 ` [PATCH v2 00/21] kconfig: move compiler capability tests " Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327172815.GH18435@arm.com \
--to=will.deacon@arm.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=nico@linaro.org \
--cc=rdunlap@infradead.org \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=ulfalizer@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox