* [PATCH] RDMA/hns: ensure for-loop actually iterates and free's buffers
@ 2018-03-26 15:10 Colin King
2018-03-27 7:14 ` Liuyixian (Eason)
2018-03-27 21:08 ` Jason Gunthorpe
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2018-03-26 15:10 UTC (permalink / raw)
To: Lijun Ou, Wei Hu, Doug Ledford, Jason Gunthorpe, linux-rdma
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The current for-loop zeros variable i and only loops once, hence
not all the buffers are free'd. Fix this by setting i correctly.
Detected by CoverityScan, CID#1463415 ("Operands don't affect result")
Fixes: a5073d6054f7 ("RDMA/hns: Add eq support of hip08")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
index 684c2d1a0ed0..8b84ab7800d8 100644
--- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
+++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
@@ -4391,7 +4391,7 @@ static int hns_roce_mhop_alloc_eq(struct hns_roce_dev *hr_dev,
eq->l0_dma = 0;
if (mhop_num == 1)
- for (i -= i; i >= 0; i--)
+ for (i -= 1; i >= 0; i--)
dma_free_coherent(dev, buf_chk_sz, eq->buf[i],
eq->buf_dma[i]);
else if (mhop_num == 2) {
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] RDMA/hns: ensure for-loop actually iterates and free's buffers
2018-03-26 15:10 [PATCH] RDMA/hns: ensure for-loop actually iterates and free's buffers Colin King
@ 2018-03-27 7:14 ` Liuyixian (Eason)
2018-03-27 21:08 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Liuyixian (Eason) @ 2018-03-27 7:14 UTC (permalink / raw)
To: Colin King, Lijun Ou, Wei Hu, Doug Ledford, Jason Gunthorpe,
linux-rdma
Cc: kernel-janitors, linux-kernel
On 2018/3/26 23:10, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The current for-loop zeros variable i and only loops once, hence
> not all the buffers are free'd. Fix this by setting i correctly.
Hi Colin,
Thank you very much for this patch! It's a typo when I prepared the patch set.
Reviewed-by: Yixian Liu <liuyixian@huawei.com>
>
> Detected by CoverityScan, CID#1463415 ("Operands don't affect result")
>
> Fixes: a5073d6054f7 ("RDMA/hns: Add eq support of hip08")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> index 684c2d1a0ed0..8b84ab7800d8 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> @@ -4391,7 +4391,7 @@ static int hns_roce_mhop_alloc_eq(struct hns_roce_dev *hr_dev,
> eq->l0_dma = 0;
>
> if (mhop_num == 1)
> - for (i -= i; i >= 0; i--)
> + for (i -= 1; i >= 0; i--)
> dma_free_coherent(dev, buf_chk_sz, eq->buf[i],
> eq->buf_dma[i]);
> else if (mhop_num == 2) {
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] RDMA/hns: ensure for-loop actually iterates and free's buffers
2018-03-26 15:10 [PATCH] RDMA/hns: ensure for-loop actually iterates and free's buffers Colin King
2018-03-27 7:14 ` Liuyixian (Eason)
@ 2018-03-27 21:08 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2018-03-27 21:08 UTC (permalink / raw)
To: Colin Ian King
Cc: Lijun Ou, Wei Hu, Doug Ledford, linux-rdma, kernel-janitors,
linux-kernel
On Mon, Mar 26, 2018 at 04:10:18PM +0100, Colin Ian King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The current for-loop zeros variable i and only loops once, hence
> not all the buffers are free'd. Fix this by setting i correctly.
>
> Detected by CoverityScan, CID#1463415 ("Operands don't affect result")
>
> Fixes: a5073d6054f7 ("RDMA/hns: Add eq support of hip08")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Reviewed-by: Yixian Liu <liuyixian@huawei.com>
> ---
> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-rc, thanks
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-27 21:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-26 15:10 [PATCH] RDMA/hns: ensure for-loop actually iterates and free's buffers Colin King
2018-03-27 7:14 ` Liuyixian (Eason)
2018-03-27 21:08 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox