public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Sebastian Ott <sebott@linux.vnet.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>,
	Jesper Nilsson <jesper.nilsson@axis.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-kernel@vger.kernel.org
Subject: Re: dma_zalloc_coherent broken with 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7
Date: Wed, 28 Mar 2018 13:57:03 +0200	[thread overview]
Message-ID: <20180328115703.GA31426@lst.de> (raw)
In-Reply-To: <alpine.LFD.2.21.1803271900390.18934@schleppi>

On Tue, Mar 27, 2018 at 07:04:51PM +0200, Sebastian Ott wrote:
> What was wrong with the old behavior (let the caller decide - the same
> as with memory allocations)?

The old behavior on most (all?) mainstream architectures is that we
always zero the return value.  On x86/i386 this goes back to at least
Linux 2.4.  So common drivers simply expect this to happen.

      reply	other threads:[~2018-03-28 11:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-27  8:12 dma_zalloc_coherent broken with 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7 Sebastian Ott
2018-03-27  8:21 ` Geert Uytterhoeven
2018-03-27  8:41   ` Sebastian Ott
2018-03-27  8:51     ` Geert Uytterhoeven
2018-03-27 14:33 ` Christoph Hellwig
2018-03-27 15:24   ` Sebastian Ott
2018-03-27 16:45     ` Christoph Hellwig
2018-03-27 17:04       ` Sebastian Ott
2018-03-28 11:57         ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180328115703.GA31426@lst.de \
    --to=hch@lst.de \
    --cc=geert@linux-m68k.org \
    --cc=jesper.nilsson@axis.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sebott@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox