From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH 1/2] KVM: X86: Fix setup the virt_spin_lock_key before static key get initialized
Date: Wed, 28 Mar 2018 22:19:05 +0200 [thread overview]
Message-ID: <20180328201905.GF26753@flask> (raw)
In-Reply-To: <1521951444-5087-1-git-send-email-wanpengli@tencent.com>
2018-03-24 21:17-0700, Wanpeng Li:
> From: Wanpeng Li <wanpengli@tencent.com>
>
> static_key_disable_cpuslocked(): static key 'virt_spin_lock_key+0x0/0x20' used before call to jump_label_init()
> WARNING: CPU: 0 PID: 0 at kernel/jump_label.c:161 static_key_disable_cpuslocked+0x61/0x80
> RIP: 0010:static_key_disable_cpuslocked+0x61/0x80
> Call Trace:
> static_key_disable+0x16/0x20
> start_kernel+0x192/0x4b3
> secondary_startup_64+0xa5/0xb0
>
> Qspinlock will be choosed when dedicated pCPUs are available, however, the
> static virt_spin_lock_key is set in kvm_spinlock_init() before jump_label_init()
> has been called, which will result in a WARN(). This patch fixes it by delaying
> the virt_spin_lock_key setup to .smp_prepare_cpus().
>
> Reported-by: Davidlohr Bueso <dbueso@suse.de>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Radim Krčmář <rkrcmar@redhat.com>
> Cc: Davidlohr Bueso <dbueso@suse.de>
> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
> ---
Queued, thanks.
prev parent reply other threads:[~2018-03-28 20:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-25 4:17 [PATCH 1/2] KVM: X86: Fix setup the virt_spin_lock_key before static key get initialized Wanpeng Li
2018-03-26 0:27 ` Davidlohr Bueso
2018-03-26 14:10 ` Wanpeng Li
2018-03-26 22:32 ` Davidlohr Bueso
2018-03-27 0:52 ` Wanpeng Li
2018-03-27 16:29 ` Davidlohr Bueso
2018-03-28 0:45 ` Wanpeng Li
2018-03-28 20:19 ` Radim Krčmář [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180328201905.GF26753@flask \
--to=rkrcmar@redhat.com \
--cc=dbueso@suse.de \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox