From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH v2] perf, pt, coresight: Clean up address filter structure
Date: Thu, 29 Mar 2018 16:06:06 +0200 [thread overview]
Message-ID: <20180329140606.zcomu2u2xzyss4tm@gmail.com> (raw)
In-Reply-To: <20180329121036.GZ4043@hirez.programming.kicks-ass.net>
* Peter Zijlstra <peterz@infradead.org> wrote:
> On Thu, Mar 29, 2018 at 03:06:48PM +0300, Alexander Shishkin wrote:
> > This is a cosmetic patch that deals with the address filter structure's
> > ambiguous fields 'filter' and 'range'. The former stands to mean that the
> > filter's *action* should be to filter the traces to its address range if
> > it's set or stop tracing if it's unset. This is confusing and hard on the
> > eyes, so this patch replaces it with 'action' enum. The 'range' field is
> > completely redundant (meaning that the filter is an address range as
> > opposed to a single address trigger), as we can use zero size to mean the
> > same thing.
> >
> > Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> > Acked-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>
> Ingo, can you merge this?
Sure, will do!
Thanks,
Ingo
next prev parent reply other threads:[~2018-03-29 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 12:06 [PATCH v2] perf, pt, coresight: Clean up address filter structure Alexander Shishkin
2018-03-29 12:10 ` Peter Zijlstra
2018-03-29 14:06 ` Ingo Molnar [this message]
2018-03-29 14:58 ` [tip:perf/core] perf/x86/pt, " tip-bot for Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180329140606.zcomu2u2xzyss4tm@gmail.com \
--to=mingo@kernel.org \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox