From: Greg KH <gregkh@linuxfoundation.org>
To: Quytelda Kahja <quytelda@tamalin.org>
Cc: wsa@the-dreams.de, devel@driverdev.osuosl.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/76] staging: ks7010: Remove trailing _t from 'struct hostif_mib_set_confirm_t'.
Date: Fri, 30 Mar 2018 12:00:58 +0200 [thread overview]
Message-ID: <20180330100058.GA19140@kroah.com> (raw)
In-Reply-To: <20180330070842.25224-12-quytelda@tamalin.org>
On Fri, Mar 30, 2018 at 12:07:35AM -0700, Quytelda Kahja wrote:
> The "_t" suffix is not needed for structure names in this driver, and is a
> reflection of an older typedef system that is no longer in place. Replace
> all occurences of 'struct hostif_mib_set_confirm_t' with 'struct
> hostif_mib_set_confirm'.
>
> Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
> ---
> drivers/staging/ks7010/ks_hostif.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
> index 5261810fbc76..7a0e0c610c50 100644
> --- a/drivers/staging/ks7010/ks_hostif.h
> +++ b/drivers/staging/ks7010/ks_hostif.h
> @@ -175,7 +175,7 @@ struct hostif_mib_set_request {
> struct hostif_mib_value mib_value;
> } __packed;
>
> -struct hostif_mib_set_confirm_t {
> +struct hostif_mib_set_confirm {
> struct hostif_hdr header;
> __le32 mib_status;
> __le32 mib_attribute;
As Joe points out, please just remove structures that are not used at
all, it's pointless to keep them around.
thanks,
greg k-h
next prev parent reply other threads:[~2018-03-30 10:00 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 7:07 [PATCH 01/76] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes Quytelda Kahja
2018-03-30 7:07 ` [PATCH 02/76] staging: ks7010: Remove trailing _t from 'struct wpa_suite_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 03/76] staging: ks7010: Remove trailing _t from 'struct rsn_mode_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 04/76] staging: ks7010: Remove trailing _t from 'struct pmk_cache_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 05/76] staging: ks7010: Remove trailing _t from 'struct hostif_data_request_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 06/76] staging: ks7010: Remove trailing _t from 'struct hostif_data_indication_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 07/76] staging: ks7010: Remove trailing _t from 'struct channel_list_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 08/76] staging: ks7010: Remove trailing _t from 'struct hostif_mib_get_request_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 09/76] staging: ks7010: Remove trailing _t from 'struct hostif_mib_value_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 10/76] staging: ks7010: Remove trailing _t from 'struct hostif_mib_get_confirm_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 11/76] staging: ks7010: Remove trailing _t from 'struct hostif_mib_set_request_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 12/76] staging: ks7010: Remove trailing _t from 'struct hostif_mib_set_confirm_t' Quytelda Kahja
2018-03-30 7:44 ` Joe Perches
2018-03-30 10:00 ` Greg KH [this message]
2018-03-30 7:07 ` [PATCH 13/76] staging: ks7010: Remove trailing _t from 'struct hostif_power_mgmt_request_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 14/76] staging: ks7010: Remove trailing _t from 'struct hostif_power_mgmt_confirm_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 15/76] staging: ks7010: Remove trailing _t from 'struct hostif_start_request_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 16/76] staging: ks7010: Remove trailing _t from 'struct hostif_start_confirm_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 17/76] staging: ks7010: Remove trailing _t from 'struct ssid_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 18/76] staging: ks7010: Remove trailing _t from 'struct rate_set8_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 19/76] staging: ks7010: Remove trailing _t from 'struct fh_parms_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 20/76] staging: ks7010: Remove trailing _t from 'struct ds_parms_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 21/76] staging: ks7010: Remove trailing _t from 'struct cf_parms_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 22/76] staging: ks7010: Remove trailing _t from 'struct ibss_parms_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 23/76] staging: ks7010: Remove trailing _t from 'struct rsn_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 24/76] staging: ks7010: Remove trailing _t from 'struct erp_params_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 25/76] staging: ks7010: Remove trailing _t from 'struct rate_set16_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 26/76] staging: ks7010: Remove trailing _t from 'struct ap_info_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 27/76] staging: ks7010: Remove trailing _t from 'struct link_ap_info_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 28/76] staging: ks7010: Remove trailing _t from 'struct hostif_connect_indication_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 29/76] staging: ks7010: Remove trailing _t from 'struct hostif_stop_request_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 30/76] staging: ks7010: Remove trailing _t from 'struct hostif_stop_confirm_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 31/76] staging: ks7010: Remove trailing _t from 'struct hostif_request_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 32/76] staging: ks7010: Remove trailing _t from 'struct hostif_ps_adhoc_set_request_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 33/76] staging: ks7010: Remove trailing _t from 'struct hostif_ps_adhoc_set_confirm_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 34/76] staging: ks7010: Remove trailing _t from 'struct hostif_infrastructure_set_request_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 35/76] staging: ks7010: Remove trailing _t from 'struct hostif_infrastructure_set_confirm_t' Quytelda Kahja
2018-03-30 7:07 ` [PATCH 36/76] staging: ks7010: Remove trailing _t from 'struct hostif_adhoc_set_request_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 37/76] staging: ks7010: Remove trailing _t from 'struct hostif_adhoc_set2_request_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 38/76] staging: ks7010: Remove trailing _t from 'struct hostif_adhoc_set_confirm_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 39/76] staging: ks7010: Remove trailing _t from 'struct last_associate_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 40/76] staging: ks7010: Remove trailing _t from 'struct association_request_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 41/76] staging: ks7010: Remove trailing _t from 'struct association_response_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 42/76] staging: ks7010: Remove trailing _t from 'struct hostif_associate_indication_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 43/76] staging: ks7010: Remove trailing _t from 'struct hostif_bss_scan_request_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 44/76] staging: ks7010: Remove trailing _t from 'struct hostif_bss_scan_confirm_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 45/76] staging: ks7010: Remove trailing _t from 'struct hostif_phy_information_request_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 46/76] staging: ks7010: Remove trailing _t from 'struct hostif_phy_information_confirm_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 47/76] staging: ks7010: Remove trailing _t from 'struct hostif_sleep_request_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 48/76] staging: ks7010: Remove trailing _t from 'struct hostif_sleep_confirm_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 49/76] staging: ks7010: Remove trailing _t from 'struct hostif_mic_failure_request_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 50/76] staging: ks7010: Remove trailing _t from 'struct hostif_mic_failure_confirm_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 51/76] staging: ks7010: Remove trailing _t from 'struct hostt_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 52/76] staging: ks7010: Remove trailing _t from 'struct rsn_ie_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 53/76] staging: ks7010: Remove trailing _t from 'struct wps_ie_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 54/76] staging: ks7010: Remove trailing _t from 'struct local_ap_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 55/76] staging: ks7010: Remove trailing _t from 'struct local_aplist_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 56/76] staging: ks7010: Remove trailing _t from 'struct local_gain_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 57/76] staging: ks7010: Remove trailing _t from 'struct local_eeprom_sum_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 58/76] staging: ks7010: Remove trailing _t from 'struct power_save_status_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 59/76] staging: ks7010: Remove trailing _t from 'struct sleep_status_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 60/76] staging: ks7010: Remove trailing _t from 'struct scan_ext_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 61/76] staging: ks7010: Remove trailing _t from 'struct wpa_key_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 62/76] staging: ks7010: Remove trailing _t from 'struct mic_failure_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 63/76] staging: ks7010: Remove trailing _t from 'struct wpa_status_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 64/76] staging: ks7010: Remove trailing _t from 'struct pmk_list_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 65/76] staging: ks7010: Remove trailing _t from 'struct pmk_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 66/76] staging: ks7010: Remove trailing _t from 'struct wps_status_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 67/76] staging: ks7010: Remove trailing _t from 'struct michael_mic_t' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 68/76] staging: ks7010: Replace manual array copy with ether_addr_copy() Quytelda Kahja
2018-03-30 7:08 ` [PATCH 69/76] staging: ks7010: Remove 'eth_addr' field from 'struct ks_wlan_private' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 70/76] staging: ks7010: Remove extra blank line between functions Quytelda Kahja
2018-03-30 7:08 ` [PATCH 70/72] staging: ks7010: Rename ks_wlan_set_multicast_list() Quytelda Kahja
2018-03-30 7:08 ` [PATCH 71/72] staging: ks7010: Remove 'eth_addr' field from 'struct ks_wlan_private' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 71/76] staging: ks7010: Rename ks_wlan_set_multicast_list() Quytelda Kahja
2018-03-30 7:08 ` [PATCH 72/76] staging: ks7010: Remove dummy address set Quytelda Kahja
2018-03-30 7:08 ` [PATCH 72/72] staging: ks7010: Remove extra blank line between functions Quytelda Kahja
2018-03-30 7:08 ` [PATCH 73/76] staging: ks7010: Change 'device_open_status' to a bool Quytelda Kahja
2018-03-30 7:08 ` [PATCH 74/76] staging: ks7010: Remove unnecessary casts in 'struct ks_wlan_handler_def' Quytelda Kahja
2018-03-30 7:08 ` [PATCH 75/76] staging: ks7010: Replace memcmp() with ether_addr_equal() Quytelda Kahja
2018-03-30 7:08 ` [PATCH 76/76] staging: ks7010: Replace memcpy() with ether_addr_copy() Quytelda Kahja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180330100058.GA19140@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quytelda@tamalin.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox