From: Ingo Molnar <mingo@kernel.org>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: linux-kernel@vger.kernel.org, viro@ZenIV.linux.org.uk,
torvalds@linux-foundation.org, arnd@arndb.de,
linux-arch@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Andi Kleen <ak@linux.intel.com>, Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@kernel.org>,
Denys Vlasenko <dvlasenk@redhat.com>,
Brian Gerst <brgerst@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org
Subject: Re: [PATCH 7/7] x86/entry/64: extend register clearing on syscall entry to lower registers
Date: Fri, 30 Mar 2018 12:10:20 +0200 [thread overview]
Message-ID: <20180330101020.6g2pib3xaftawl5h@gmail.com> (raw)
In-Reply-To: <20180330093720.6780-8-linux@dominikbrodowski.net>
* Dominik Brodowski <linux@dominikbrodowski.net> wrote:
> .endif
> pushq \rdx /* pt_regs->dx */
> + xorl %edx, %edx /* nosepc dx */
> pushq %rcx /* pt_regs->cx */
> + xorl %ecx, %ecx /* nosepc cx */
> pushq \rax /* pt_regs->ax */
> pushq %r8 /* pt_regs->r8 */
> xorl %r8d, %r8d /* nospec r8 */
> diff --git a/arch/x86/entry/entry_64_compat.S b/arch/x86/entry/entry_64_compat.S
> index 08425c42f8b7..23e0945959e5 100644
> --- a/arch/x86/entry/entry_64_compat.S
> +++ b/arch/x86/entry/entry_64_compat.S
> @@ -220,8 +220,11 @@ GLOBAL(entry_SYSCALL_compat_after_hwframe)
> pushq %rax /* pt_regs->orig_ax */
> pushq %rdi /* pt_regs->di */
> pushq %rsi /* pt_regs->si */
> + xorl %esi, %esi /* nosepc si */
> pushq %rdx /* pt_regs->dx */
> + xorl %edx, %edx /* nosepc dx */
> pushq %rbp /* pt_regs->cx (stashed in bp) */
> + xorl %ecx, %ecx /* nosepc cx */
> pushq $-ENOSYS /* pt_regs->ax */
> pushq $0 /* pt_regs->r8 = 0 */
> xorl %r8d, %r8d /* nospec r8 */
> @@ -365,8 +368,11 @@ ENTRY(entry_INT80_compat)
>
> pushq (%rdi) /* pt_regs->di */
> pushq %rsi /* pt_regs->si */
> + xorl %esi, %esi /* nosepc si */
> pushq %rdx /* pt_regs->dx */
> + xorl %edx, %edx /* nosepc dx */
> pushq %rcx /* pt_regs->cx */
> + xorl %ecx, %ecx /* nosepc cx */
> pushq $-ENOSYS /* pt_regs->ax */
> pushq $0 /* pt_regs->r8 = 0 */
> xorl %r8d, %r8d /* nospec r8 */
s/nosepc
/nospec
Thanks,
Ingo
next prev parent reply other threads:[~2018-03-30 10:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 9:37 [PATCH 0/7] use struct pt_regs based syscall calling for x86-64 Dominik Brodowski
2018-03-30 9:37 ` [PATCH 1/7] x86: don't pointlessly reload the system call number Dominik Brodowski
2018-03-30 9:37 ` [PATCH 2/7] syscalls: introduce CONFIG_ARCH_HAS_SYSCALL_WRAPPER Dominik Brodowski
2018-03-30 9:37 ` [PATCH 3/7] syscalls/x86: use struct pt_regs based syscall calling for 64bit syscalls Dominik Brodowski
2018-03-30 9:37 ` [PATCH 4/7] syscalls: prepare ARCH_HAS_SYSCALL_WRAPPER for compat syscalls Dominik Brodowski
2018-03-30 9:37 ` [PATCH 5/7] syscalls/x86: use struct pt_regs based syscall calling for IA32_EMULATION and x32 Dominik Brodowski
2018-03-30 9:37 ` [PATCH 6/7] syscalls/x86: unconditionally enable struct pt_regs based syscalls on x86_64 Dominik Brodowski
2018-03-30 9:37 ` [PATCH 7/7] x86/entry/64: extend register clearing on syscall entry to lower registers Dominik Brodowski
2018-03-30 10:10 ` Ingo Molnar [this message]
2018-03-30 10:16 ` [PATCH 0/7] use struct pt_regs based syscall calling for x86-64 Ingo Molnar
2018-03-30 10:46 ` Dominik Brodowski
2018-03-30 11:03 ` Ingo Molnar
2018-03-30 11:48 ` Dominik Brodowski
2018-03-30 12:00 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180330101020.6g2pib3xaftawl5h@gmail.com \
--to=mingo@kernel.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox