From: Borislav Petkov <bp@alien8.de>
To: Khan M Rashedun-Naby <naby88@gmail.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, thomas.lendacky@amd.com, jgross@suse.com,
r.marek@assembler.cz, qianyue.zj@alibaba-inc.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixed some style warnings and errors
Date: Mon, 2 Apr 2018 18:17:08 +0200 [thread overview]
Message-ID: <20180402161708.GA22516@pd.tnic> (raw)
In-Reply-To: <1522682263-11935-1-git-send-email-naby88@gmail.com>
On Mon, Apr 02, 2018 at 09:17:43PM +0600, Khan M Rashedun-Naby wrote:
> @@ -820,14 +821,22 @@ static void init_amd(struct cpuinfo_x86 *c)
> clear_cpu_cap(c, X86_FEATURE_MCE);
>
> switch (c->x86) {
> - case 4: init_amd_k5(c); break;
> - case 5: init_amd_k6(c); break;
> - case 6: init_amd_k7(c); break;
> - case 0xf: init_amd_k8(c); break;
> - case 0x10: init_amd_gh(c); break;
> - case 0x12: init_amd_ln(c); break;
> - case 0x15: init_amd_bd(c); break;
> - case 0x17: init_amd_zn(c); break;
> + case 4:
> + init_amd_k5(c); break;
> + case 5:
> + init_amd_k6(c); break;
> + case 6:
> + init_amd_k7(c); break;
> + case 0xf:
> + init_amd_k8(c); break;
> + case 0x10:
> + init_amd_gh(c); break;
> + case 0x12:
> + init_amd_ln(c); break;
> + case 0x15:
> + init_amd_bd(c); break;
> + case 0x17:
> + init_amd_zn(c); break;
No, it was compact and more readable before.
In general, I'd very much advise *not* to do checkpatch-only patches.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-04-02 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 15:17 [PATCH] Fixed some style warnings and errors Khan M Rashedun-Naby
2018-04-02 16:17 ` Borislav Petkov [this message]
[not found] ` <CANOsoeva82vod1QDHoJiJr2bBAmD7hULZVowebK9yrpF+5cpOQ@mail.gmail.com>
2018-04-02 16:43 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180402161708.GA22516@pd.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=naby88@gmail.com \
--cc=qianyue.zj@alibaba-inc.com \
--cc=r.marek@assembler.cz \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox