public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Khan M Rashedun-Naby <naby88@gmail.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, thomas.lendacky@amd.com, jgross@suse.com,
	r.marek@assembler.cz, qianyue.zj@alibaba-inc.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixed some style warnings and errors
Date: Mon, 2 Apr 2018 18:43:33 +0200	[thread overview]
Message-ID: <20180402164333.GB21609@pd.tnic> (raw)
In-Reply-To: <CANOsoeva82vod1QDHoJiJr2bBAmD7hULZVowebK9yrpF+5cpOQ@mail.gmail.com>

On Mon, Apr 02, 2018 at 10:24:36PM +0600, Khan M Rashedun-Naby wrote:
> Thanks Borislav, but what about the data type fix ? :)

First of all, please do not top-post when replying to lkml email and
also, when replying, hit reply-to-all so that all the people on CC can
get the answer. I've fixed that now.

For a more detailed discussion on the whole process, take a look at

Documentation/process/

or alternatively at a well-formatted version:

https://www.kernel.org/doc/html/latest/process/index.html

Now to your question: forget the "data type fix" - that will be
addressed when we touch that code at some point anyway. Pure checkpatch
patches only dilute git history and don't really help.

If you really want to get involved, try fixing real
bugs like fixing drivers in staging, for example.
https://kernelnewbies.org/FirstKernelPatch has a very detailed
explanation how to do that.

HTH.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

      parent reply	other threads:[~2018-04-02 16:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-02 15:17 [PATCH] Fixed some style warnings and errors Khan M Rashedun-Naby
2018-04-02 16:17 ` Borislav Petkov
     [not found]   ` <CANOsoeva82vod1QDHoJiJr2bBAmD7hULZVowebK9yrpF+5cpOQ@mail.gmail.com>
2018-04-02 16:43     ` Borislav Petkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180402164333.GB21609@pd.tnic \
    --to=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=naby88@gmail.com \
    --cc=qianyue.zj@alibaba-inc.com \
    --cc=r.marek@assembler.cz \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox