From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754524AbeDBWBl (ORCPT ); Mon, 2 Apr 2018 18:01:41 -0400 Received: from mail-yw0-f178.google.com ([209.85.161.178]:43168 "EHLO mail-yw0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754371AbeDBWBj (ORCPT ); Mon, 2 Apr 2018 18:01:39 -0400 X-Google-Smtp-Source: AIpwx4/mCAlR8eNN+gfVtkmlSg/bonfi08gsuuAVQrw13fZQxJk/1n1+JwElOWd+PAVnzH1Hi5huyw== Date: Mon, 2 Apr 2018 15:01:36 -0700 From: "tj@kernel.org" To: Bart Van Assche Cc: "kernel-team@fb.com" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "axboe@kernel.dk" Subject: Re: [PATCH 2/2] blk-mq: Fix request handover from timeout path to normal execution Message-ID: <20180402220136.GI388343@devbig577.frc2.facebook.com> References: <20180402190053.GC388343@devbig577.frc2.facebook.com> <20180402190120.GD388343@devbig577.frc2.facebook.com> <20180402211047.GF388343@devbig577.frc2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Mon, Apr 02, 2018 at 09:56:41PM +0000, Bart Van Assche wrote: > This patch increases the time during which .aborted_gstate == .gstate if the > timeout is reset. Does that increase the chance that a completion will be missed > if the request timeout is reset? It sure does, but we're comparing an outright kernel bug vs. an inherently opportunistic mechanism being a bit more lossy. I think the answer is pretty clear. Thanks. -- tejun