Re: [PATCH AUTOSEL for 4.15 058/124] ipv6: Set nexthop flags during route creation

Ido Schimmel
2018-03-19T18:05:13Z

On Mon, Mar 19, 2018 at 03:48:00PM +0000, Sasha Levin wrote:
> From: Ido Schimmel <idosch@mellanox.com>
>
> [ Upstream commit 5609b80a37f69f796548339e675256188b29c17d ]
>
> It is valid to install routes with a nexthop device that does not have a
> carrier, so we need to make sure they're marked accordingly.
>
> As explained in the previous patch, host and anycast routes are never
> marked with the 'linkdown' flag.
>
> Note that reject routes are unaffected, as these use the loopback device
> which always has a carrier.
>
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> Acked-by: David Ahern <dsahern@gmail.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>

Hi Sasha,

It doesn't really make sense to take this patch to 4.15 (and 4.14 from
your other mail). The flag is never used there.

In these kernels the flag is dumped to user space based on a carrier
check. See commit 44c9f2f206f8 ("ipv6: Check nexthop flags in route dump
instead of carrier").

Similarly, during route lookup the carrier is checked and not the flag.
See commit 14c5206c2d02 ("ipv6: Check nexthop flags during route lookup
instead of carrier").

Thanks