Re: [PATCH] perf trace: remove redundant ')'

Arnaldo Carvalho de Melo
2018-03-16T12:50:50Z

Em Fri, Mar 16, 2018 at 03:51:09PM +0800, Du, Changbin escreveu:
> Hi Arnaldo, How about this simple one? Thanks.
>
> On Tue, Mar 13, 2018 at 06:40:01PM +0800, changbin.du@intel.com wrote:
> > From: Changbin Du <changbin.du@intel.com>
> >
> > There is a redundant ')' at the tail of each event. So remove it.
> > $ sudo perf trace --no-syscalls -e 'kmem:*' -a
> > 899.342 kmem:kfree:(vfs_writev+0xb9) call_site=ffffffff9c453979 ptr=(nil))
> > 899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=ffffffff9c9b8b88 ptr=(nil))
> >
> > Signed-off-by: Changbin Du <changbin.du@intel.com>
> > ---
> > tools/perf/builtin-trace.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> > index e7f1b18..7273f5f 100644
> > --- a/tools/perf/builtin-trace.c
> > +++ b/tools/perf/builtin-trace.c
> > @@ -1959,7 +1959,7 @@ static int trace__event_handler(struct trace *trace, struct perf_evsel *evsel,
> > trace->output);
> > }
> >
> > - fprintf(trace->output, ")\n");
> > + fprintf(trace->output, "\n");

It looks simple on the surface, but I couldn't quickly recall why this
')' was put there in the first place... So I left for later to do a 'git
blame' on this file, etc.

- Arnaldo

> > if (callchain_ret > 0)
> > trace__fprintf_callchain(trace, sample);
> > --
> > 2.7.4
> >
>
> --
> Thanks,
> Changbin Du