From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-673690-1522867308-2-1428169811445760234 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.249, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: to='iso-8859-1', plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1522867307; b=PjwXrd92XHQWZbmsTtMRmyUrjJlkZ/nOJu8Rp4aiyXvHMaFjSV fjxJXhydYSRFVNsKKaK3kk8NmEqmZTWIJTm6Mw11PASr1vzZVTeef2NrJXoH3f/j LzF7RsVR6QZCm2QHU1uZ0eS42ZZDKJIjaT0cf5QOqytTVpSLJpIpaefaUF7BC81a LkK+fX4cMrAzr039b7IOKdxLQQZjnyWG/r8WngIuzyFh1pj7CibBRBZss0s979Z4 zDP+apNwxmJ0VRmho4fLPP81vm3iZZ4sxAVA512w9KSHqE6mFHWtZn9mPbXC/NGl 2j3sFxQqNW7eenOrXI8zZuiXSRjX+kvl4TAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:content-transfer-encoding :in-reply-to:sender:list-id; s=fm2; t=1522867307; bh=ZWaTkYlELZK o0gjUGZN37aVP+lLoYWwFKQf3jiq6UPg=; b=PHZDRFlS+E0Kq6O7My9hTgNrqIg p7fxINARFlBZheFMrIowvhvZ2C5+KYI4KOp9nbKZAJZPNKHLYBilKHJtD4I28PIH P3YWMUHmWoAkP9GDmA6WXB5C4+NgXY7fGp5olACplNom9aAZaJeREMPA2rq1+dJe SxF/8Vc1cmkO6ol5ztaAyUGHbSiXjVcAtaLQ5xXSMPnLHDOeSNS7PHNsEsjybfFn BAi8jM20quO/e7EvDkBZbKS4IRDSVRfunWNcEyiWsD1XxheFHKrMscZr0Gyiy3P8 24BYVQaSL3F3o9ZvOTmrSzwFaBgmB5JQz9PFHmpwKsPyMbbRX1b/27V37Lg== ARC-Authentication-Results: i=1; mx1.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=intel.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=intel.com header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx1.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=intel.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=intel.com header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfF6pWXh3kVyzY+9dgDjUiKoPoD9uyZew5cf4q18qs/bQRyO7WaN5lFgc9NMdwqcRTbvTDCKbkc8/v8uNtbn5P4af58DcO0pXQ+NwC9CEUx7G0Yao6sIz 1kWLR/86yaSEAVgo7NWQebyn+szNcYh86zsynPFHMYj4HPoqFuWG7sshw7IjcgFv/R2EUGtaHLokUhux2ZZeumNGYY2j1OcdKd18eDem39b15MF6VxkUq2Ab X-CM-Analysis: v=2.3 cv=WaUilXpX c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=8nJEP1OIZ-IA:10 a=Kd1tUaAdevIA:10 a=20KFwNOVAAAA:8 a=QyXUC8HyAAAA:8 a=VwQbUJbxAAAA:8 a=e5mUnYsNAAAA:8 a=i0_Obo9wnmxgy_uwGYEA:9 a=wPNLvfGTeEIA:10 a=AjGcO6oz07-iQ99wixmX:22 a=Vxmtnl_E_bksehYqCbjh:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751410AbeDDSlp (ORCPT ); Wed, 4 Apr 2018 14:41:45 -0400 Received: from mga02.intel.com ([134.134.136.20]:19101 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751356AbeDDSlp (ORCPT ); Wed, 4 Apr 2018 14:41:45 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,407,1517904000"; d="scan'208";a="31044119" Date: Wed, 4 Apr 2018 11:44:36 -0700 From: Manasi Navare To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Lyude Paul , dri-devel@lists.freedesktop.org, David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dhinakaran Pandiyan , Rodrigo Vivi , stable@vger.kernel.org, Laura Abbott Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST Message-ID: <20180404184435.GA2804@intel.com> References: <20180402212142.19841-1-lyude@redhat.com> <20180402212617.21247-1-lyude@redhat.com> <20180404153429.GE5453@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180404153429.GE5453@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, Apr 04, 2018 at 06:34:29PM +0300, Ville Syrjälä wrote: > On Mon, Apr 02, 2018 at 05:26:16PM -0400, Lyude Paul wrote: > > While enabling/disabling DPMS before link training with MST hubs is > > perfectly valid; unfortunately disabling DPMS results in some devices > > disabling their AUX CH block as well. For SST this isn't as much of a > > problem, but for MST we need to be able to continue handling aux > > transactions even when none of the sinks are turned on since it's > > possible for us to have a single atomic commit which results in > > disabling each downstream sink, followed by subsequently re-enabling > > each sink. > > > > If we don't do this, we'll end up stalling any pending ESI interrupts > > from the sink for up to 1ms. Unfortunately, dropping ESIs during this > > timespan makes it so that link fallback retraining for MST (which I will > > be submitting to the ML shortly) fails due to the channel EQ failure > > interrupts potentially getting dropped. Additionally, when performing a > > modeset that brings the hub status's link status from bad -> good having > > ESIs disabled for that long causes us to miss the hub's response to us > > trying to start link training as well. > > > > Since any sink with MST is going to support DisplayPort 1.2 anyway, save > > us the hassle of trying to wait until the sink comes back up and just > > never shut the aux block down. > > > > Changes since v2: > > - Fix patch name, no functional changes > > > > Signed-off-by: Lyude Paul > > Cc: Laura Abbott > > Cc: Dhinakaran Pandiyan > > Cc: Ville Syrjälä > > Cc: stable@vger.kernel.org > > Fixes: ad260ab32a4d9 ("drm/i915/dp: Write to SET_POWER dpcd to enable MST hub.") > > --- > > drivers/gpu/drm/i915/intel_dp.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > > index 62f82c4298ac..0479c377981b 100644 > > --- a/drivers/gpu/drm/i915/intel_dp.c > > +++ b/drivers/gpu/drm/i915/intel_dp.c > > @@ -2589,11 +2589,13 @@ void intel_dp_sink_dpms(struct intel_dp *intel_dp, int mode) > > return; > > > > if (mode != DRM_MODE_DPMS_ON) { > > + unsigned char data = intel_dp->is_mst ? > > + DP_SET_POWER_D3_AUX_ON : DP_SET_POWER_D3; > > This smells like a workaround for an actual bug somewhere. Why exactly > is the slower wakeup or the AUX block a problem for MST but not for SST > when the link training is exactly the same for SST and MST? > The problem occurs only in case of MST because the Channel EQ failure is notified through ESI sideband AUX messages which potentially can get dropped because of disabling DPMS. But in case of SST, we detect the channel EQ failure write during the EQ TPS sequence which happens on the main link. Manasi > > + > > if (downstream_hpd_needs_d0(intel_dp)) > > return; > > > > - ret = drm_dp_dpcd_writeb(&intel_dp->aux, DP_SET_POWER, > > - DP_SET_POWER_D3); > > + ret = drm_dp_dpcd_writeb(&intel_dp->aux, DP_SET_POWER, data); > > } else { > > struct intel_lspcon *lspcon = dp_to_lspcon(intel_dp); > > > > -- > > 2.14.3 > > -- > Ville Syrjälä > Intel OTC > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx