From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 5 Apr 2018 14:30:18 +0200 From: gregkh To: Laurentiu Tudor Cc: Andrew Lunn , Stuart Yoder , Arnd Bergmann , Ioana Ciornei , Linux Kernel Mailing List , Ruxandra Ioana Ciocoi Radulescu , Razvan Stefanescu , Roy Pledge , Networking Subject: Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support Message-ID: <20180405123018.GA17751@kroah.com> References: <20180404010549.GA12443@lunn.ch> <20180404124246.GA20869@lunn.ch> <5AC5FAA8.80409@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5AC5FAA8.80409@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Thu, Apr 05, 2018 at 10:30:01AM +0000, Laurentiu Tudor wrote: > Hello, > > My 2c below. > > On 04/04/2018 03:42 PM, Andrew Lunn wrote: > >> I hear you. It is more complicated this way...having all these individual > >> objects vs just a single "bundle" of them that represents a NIC. But, that's > >> the way the DPAA2 hardware is, and we're implementing kernel support for > >> the hardware as it is. > > > > Hi Stuart > > > > I see we are not making any progress here. > > > > So what i suggest is you post the kernel code and configuration tool > > concept to netdev for a full review. You want reviews from David > > Miller, Jiri Pirko, Jakub Kicinski, David Ahern, etc. > > > > I think that the discussion steered too much towards networking related > topics, while this ioctl doesn't have much to do with networking. > It's just an ioctl for our mc-bus bus driver that is used to manage the > devices on this bus through userspace tools. > In addition, I'd drop any mention of our reference user space app > (restool) to emphasize that this ioctl is not added just for a > particular user space app. I think Stuart also mentioned this. I'm not going to take a "generic device configuration ioctl" patch unless it is documented to all exactly what it does, and why it is there. thanks, greg k-h