From: Tony Lindgren <tony@atomide.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: mapphone-mdm6600: add gpiolib dependency
Date: Thu, 5 Apr 2018 13:28:56 -0700 [thread overview]
Message-ID: <20180405202856.GK5700@atomide.com> (raw)
In-Reply-To: <20180404115614.o5h5k6h4hmpjxaed@earth.universe>
* Sebastian Reichel <sre@kernel.org> [180404 11:57]:
> Hi,
>
> On Wed, Apr 04, 2018 at 12:27:19PM +0200, Arnd Bergmann wrote:
> > Without gpiolib, the gpiod_get_array_value_cansleep() is an empty stub,
> > so gcc notices that the resulting array is never initialized:
> >
> > drivers/phy/motorola/phy-mapphone-mdm6600.c: In function 'phy_mdm6600_status':
> > drivers/phy/motorola/phy-mapphone-mdm6600.c:188:16: error: 'values[0]' is used uninitialized in this function [-Werror=uninitialized]
> > val |= values[i] << i;
> > ~~~~~~^~~
> > drivers/phy/motorola/phy-mapphone-mdm6600.c:188:16: error: 'values[1]' is used uninitialized in this function [-Werror=uninitialized]
> > drivers/phy/motorola/phy-mapphone-mdm6600.c:188:16: error: 'values[2]' is used uninitialized in this function [-Werror=uninitialized]
> > cc1: all warnings being treated as errors
> >
> > With gpiolib enabled, this can't happen and we don't get the warning, so
> > let's just add a Kconfig dependency for it.
> >
> > Fixes: 5d1ebbda0318 ("phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4")
> > Cc: Tony Lindgren <tony@atomide.com>
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Acked-by: Tony Lindgren <tony@atomide.com>
prev parent reply other threads:[~2018-04-05 20:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 10:27 [PATCH] phy: mapphone-mdm6600: add gpiolib dependency Arnd Bergmann
2018-04-04 11:56 ` Sebastian Reichel
2018-04-05 20:28 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180405202856.GK5700@atomide.com \
--to=tony@atomide.com \
--cc=arnd@arndb.de \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox