From: Viresh Kumar <viresh.kumar@linaro.org>
To: Gaurav Dhingra <gauravdhingra.gxyd@gmail.com>
Cc: driver-dev <devel@driverdev.osuosl.org>,
Alex Elder <elder@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Johan Hovold <johan@kernel.org>,
greybus-dev@lists.linaro.org
Subject: Re: [greybus-dev] [PATCH v2] staging: greybus: Fix warning to limit chars per line
Date: Fri, 6 Apr 2018 16:05:32 +0530 [thread overview]
Message-ID: <20180406103532.GA3572@vireshk-i7> (raw)
In-Reply-To: <1bb8c642-a2ba-0c8c-cab9-b4ea408eeedb@gmail.com>
On 06-04-18, 16:02, Gaurav Dhingra wrote:
> I didn't realize that it would be necessary to add it to this patch set. I
> thought you guys will do squashing of the commits (v2 and v1) and using just
> one commit message (and will take it from last commit), seems like I was
> wrong. Now I've understood it.
:)
When you send V2, it doesn't have any dependency on V1 and V1 is
discarded after that point. V2 is the full patch which should be
applied alone, we mention V2 in subject so that it is easier to track
the versions.
> >>Signed-off-by: Gaurav Dhingra <gauravdhingra.gxyd@gmail.com>
> >>---
> >>Changes in v2:
> >> - use correct format for multiline comment
> >>---
> >> drivers/staging/greybus/audio_codec.h | 5 ++++-
> >> 1 file changed, 4 insertions(+), 1 deletion(-)
> >>
> >>diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h
> >>index a1d5440..4efd8b3 100644
> >>--- a/drivers/staging/greybus/audio_codec.h
> >>+++ b/drivers/staging/greybus/audio_codec.h
> >>@@ -23,7 +23,10 @@ enum {
> >> NUM_CODEC_DAIS,
> >> };
> >>
> >>-/* device_type should be same as defined in audio.h (Android media layer) */
> >>+/*
> >>+ * device_type should be same as defined in audio.h
> >>+ * (Android media layer)
> >>+ */
> >> enum {
> >> GBAUDIO_DEVICE_NONE = 0x0,
> >> /* reserved bits */
> >This looks ok.
>
> Do I now need to send v3 with these exact changes, since I missed the
> 'commit log' in this one?
Yes please.
--
viresh
_______________________________________________
greybus-dev mailing list
greybus-dev@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/greybus-dev
prev parent reply other threads:[~2018-04-06 10:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 10:09 [greybus-dev] [PATCH v2] staging: greybus: Fix warning to limit chars per line Gaurav Dhingra
2018-04-06 10:22 ` Viresh Kumar
2018-04-06 10:32 ` Gaurav Dhingra
2018-04-06 10:35 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180406103532.GA3572@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gauravdhingra.gxyd@gmail.com \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox