* [PATCH v3] staging: greybus: Fix warning to limit chars per line
@ 2018-04-06 11:09 Gaurav Dhingra
2018-04-06 11:17 ` Vaibhav Agarwal
2018-04-06 16:05 ` [greybus-dev] " Mark Greer
0 siblings, 2 replies; 3+ messages in thread
From: Gaurav Dhingra @ 2018-04-06 11:09 UTC (permalink / raw)
To: vaibhav.sr, mgreer, johan, elder, greybus-dev, devel,
linux-kernel
Wrap comment to fix warning "prefer a maximum 75 chars per line"
Signed-off-by: Gaurav Dhingra <gauravdhingra.gxyd@gmail.com>
Acked-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
Reviewed-by: Mark Greer <mgreer@animalcreek.com>
---
Changes in v2:
- use correct format for multiline comment
Changes in v3:
- include commit log
---
drivers/staging/greybus/audio_codec.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h
index a1d5440..4efd8b3 100644
--- a/drivers/staging/greybus/audio_codec.h
+++ b/drivers/staging/greybus/audio_codec.h
@@ -23,7 +23,10 @@ enum {
NUM_CODEC_DAIS,
};
-/* device_type should be same as defined in audio.h (Android media layer) */
+/*
+ * device_type should be same as defined in audio.h
+ * (Android media layer)
+ */
enum {
GBAUDIO_DEVICE_NONE = 0x0,
/* reserved bits */
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v3] staging: greybus: Fix warning to limit chars per line
2018-04-06 11:09 [PATCH v3] staging: greybus: Fix warning to limit chars per line Gaurav Dhingra
@ 2018-04-06 11:17 ` Vaibhav Agarwal
2018-04-06 16:05 ` [greybus-dev] " Mark Greer
1 sibling, 0 replies; 3+ messages in thread
From: Vaibhav Agarwal @ 2018-04-06 11:17 UTC (permalink / raw)
To: Gaurav Dhingra; +Cc: devel, Mark Greer, linux-kernel, greybus-dev, Johan Hovold
On Fri, Apr 6, 2018 at 4:39 PM, Gaurav Dhingra
<gauravdhingra.gxyd@gmail.com> wrote:
> Wrap comment to fix warning "prefer a maximum 75 chars per line"
>
> Signed-off-by: Gaurav Dhingra <gauravdhingra.gxyd@gmail.com>
> ---
> Changes in v2:
> - use correct format for multiline comment
> Changes in v3:
> - include commit log
> ---
> drivers/staging/greybus/audio_codec.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h
> index a1d5440..4efd8b3 100644
> --- a/drivers/staging/greybus/audio_codec.h
> +++ b/drivers/staging/greybus/audio_codec.h
> @@ -23,7 +23,10 @@ enum {
> NUM_CODEC_DAIS,
> };
>
> -/* device_type should be same as defined in audio.h (Android media layer) */
> +/*
> + * device_type should be same as defined in audio.h
> + * (Android media layer)
> + */
Acked-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
--
thanks,
./va
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [greybus-dev] [PATCH v3] staging: greybus: Fix warning to limit chars per line
2018-04-06 11:09 [PATCH v3] staging: greybus: Fix warning to limit chars per line Gaurav Dhingra
2018-04-06 11:17 ` Vaibhav Agarwal
@ 2018-04-06 16:05 ` Mark Greer
1 sibling, 0 replies; 3+ messages in thread
From: Mark Greer @ 2018-04-06 16:05 UTC (permalink / raw)
To: Gaurav Dhingra; +Cc: devel, elder, linux-kernel, johan, greybus-dev
On Fri, Apr 06, 2018 at 04:39:22PM +0530, Gaurav Dhingra wrote:
> Wrap comment to fix warning "prefer a maximum 75 chars per line"
>
> Signed-off-by: Gaurav Dhingra <gauravdhingra.gxyd@gmail.com>
> ---
> Changes in v2:
> - use correct format for multiline comment
> Changes in v3:
> - include commit log
> ---
> drivers/staging/greybus/audio_codec.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h
> index a1d5440..4efd8b3 100644
> --- a/drivers/staging/greybus/audio_codec.h
> +++ b/drivers/staging/greybus/audio_codec.h
> @@ -23,7 +23,10 @@ enum {
> NUM_CODEC_DAIS,
> };
>
> -/* device_type should be same as defined in audio.h (Android media layer) */
> +/*
> + * device_type should be same as defined in audio.h
> + * (Android media layer)
> + */
> enum {
> GBAUDIO_DEVICE_NONE = 0x0,
> /* reserved bits */
> --
> 1.9.1
Reviewed-by: Mark Greer <mgreer@animalcreek.com>
_______________________________________________
greybus-dev mailing list
greybus-dev@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/greybus-dev
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-06 16:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-06 11:09 [PATCH v3] staging: greybus: Fix warning to limit chars per line Gaurav Dhingra
2018-04-06 11:17 ` Vaibhav Agarwal
2018-04-06 16:05 ` [greybus-dev] " Mark Greer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox