From: Andi Kleen <ak@linux.intel.com>
To: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1]: perf/x86: store user space frame-pointer value on a sample
Date: Fri, 6 Apr 2018 12:53:10 -0700 [thread overview]
Message-ID: <20180406195310.GB9010@tassilo.jf.intel.com> (raw)
In-Reply-To: <df5f38d8-9b35-0309-527a-c7b7b35c635b@linux.intel.com>
On Fri, Apr 06, 2018 at 10:06:26PM +0300, Alexey Budankov wrote:
> On 06.04.2018 18:31, Andi Kleen wrote:
> >> diff --git a/arch/x86/kernel/perf_regs.c b/arch/x86/kernel/perf_regs.c
> >> index e47b2dbbdef3..9284048cf5b0 100644
> >> --- a/arch/x86/kernel/perf_regs.c
> >> +++ b/arch/x86/kernel/perf_regs.c
> >> @@ -157,6 +157,15 @@ void perf_get_regs_user(struct perf_regs *regs_user,
> >> */
> >> regs_user_copy->bx = -1;
> >> regs_user_copy->bp = -1;
> >> + if (user_64bit_mode(user_regs)) {
> >
> > Why is it 64bit only? Should work on 32bit too.
>
> bp register is a part of i386 syscall ABI
> (http://man7.org/linux/man-pages/man2/syscall.2.html)
> so not sure if it will make any sense for 32bit processes.
Both 32bit and 64bit use the same frame pointer, if they
use frame pointer.
-Andi
next prev parent reply other threads:[~2018-04-06 19:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 12:49 [PATCH v1]: perf/x86: store user space frame-pointer value on a sample Alexey Budankov
2018-04-06 15:31 ` Andi Kleen
2018-04-06 19:06 ` Alexey Budankov
2018-04-06 19:53 ` Andi Kleen [this message]
2018-04-07 6:18 ` Alexey Budankov
2018-04-09 5:23 ` Alexey Budankov
2018-04-10 14:41 ` Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180406195310.GB9010@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox