From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-4029176-1523245286-2-7379927318705465022 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, MAILING_LIST_MULTI -1, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES enroda, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1523245286; b=YPSpd8Ljt7Bs9lJCeRCj9fGEZ9J/T0W033kWazZT7w6y9je8ZT bgTtXgIMNgonaB1QGuNGz37baCkQ2z6n2FWuYOYzZ2uORFeeq4Dg48Mqf14iKayo mAipgl4JgocOYq6p55QesSyqFXkbZXBsibF5ApQ7RZrEiZ5cnCCmekL0+jOcaWuh zUXRztjVPWuW7WWLYkgKbpedloF+QfJM9MvBkNCfg6Dz9nakFcByZ+q8v1cukYDs V4UQwzrpKm92h7gdJd6SwqeHHs79wMxMTDqhQ5k6coNxrWNtkAPy0h1aKr787lWn aiyE9hrxWlyDYwv9/+ANy+4L7QfQEW9vOa5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=fm2; t=1523245286; bh=aQGP3eHkMT uvtCbV61+S8FcXLryeLxDt6mMomRW3Wxo=; b=NNi49BVMjb0U0D9cz0zewif1GN 5rV3ABb2OPyV1hPV3c9xkgCMvyPkshO44Ts6CTuzGPvDcAsi9A7cHJ5FhY5YQjHQ mtdg/Bza5R3WhtjBhU4+3WkAM2wd9XQorh9FWQuUE7TS3GrvDPaTU2eFEClvIKUp 7N1iusiRDSHcL4WN3xsj6C/Fy/F36Zw8VFo9ePYtSG8zrhM3mK1Sqiq/SQXAAbzg PUtdRWg0g9RybhJ4sWtem5XqIGrJIr4mRq1AUdn5fxHsExDkF2mFrLgeStCPUJQW ijwputw2+APtooyKVuGtk29P3epYKa0LCg3dCCJc+pXKkuPVcp9ltfAXe4Kg== ARC-Authentication-Results: i=1; mx4.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=VETxrMbT x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx4.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=VETxrMbT x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfNm1KfifG3tZlaWFspe+mYxUqIXBRT6akgwV819EhSJoC/W6WWI/NsxtCBgml/Dt6HrGIFse2gvnBjX/ZqymCgnf+GiWjMXJg4ERu4ctEAWfghEtZL1Y SMXyrInNi2ds99+fn1PHmA2M+hc8r6yWYaKEzw1VriX6FEC9p9jxKS/S/zizuSkp3SGXO7jG6quwIV3PLRZ3vjCOUX9mpeVVT88lqhUeiTKVX19MhLhQQHqn X-CM-Analysis: v=2.3 cv=JLoVTfCb c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=wRwT6uffUbIA:10 a=t_PdEiP4ckcA:10 a=mw6kJ3eo-EIA:10 a=8nJEP1OIZ-IA:10 a=xqWC_Br6kY4A:10 a=Kd1tUaAdevIA:10 a=Lf-vpJhqX20A:10 a=yPCof4ZbAAAA:8 a=CbDCq_QkAAAA:8 a=20KFwNOVAAAA:8 a=J1Y8HTJGAAAA:8 a=yMhMjlubAAAA:8 a=EePCTitOv4r-aG-WyjYA:9 a=OFdCgW_wg3rEB3Yd:21 a=LkQsyN4xvfA9J7OS:21 a=wPNLvfGTeEIA:10 a=1qrBK16LubpBFNPVNq2M:22 a=y1Q9-5lHfBjTkpIzbSAN:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753165AbeDIDk4 (ORCPT ); Sun, 8 Apr 2018 23:40:56 -0400 Received: from mail-sn1nam01on0114.outbound.protection.outlook.com ([104.47.32.114]:12752 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754360AbeDIAVF (ORCPT ); Sun, 8 Apr 2018 20:21:05 -0400 From: Sasha Levin To: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Guanglei Li , Honglei Wang , "David S . Miller" , Sasha Levin Subject: [PATCH AUTOSEL for 4.15 155/189] RDS: IB: Fix null pointer issue Thread-Topic: [PATCH AUTOSEL for 4.15 155/189] RDS: IB: Fix null pointer issue Thread-Index: AQHTz5hX1+KGJxvn5EqF2AvSM4xc4w== Date: Mon, 9 Apr 2018 00:18:53 +0000 Message-ID: <20180409001637.162453-155-alexander.levin@microsoft.com> References: <20180409001637.162453-1-alexander.levin@microsoft.com> In-Reply-To: <20180409001637.162453-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR2101MB0920;7:KTI3OJhGFp00rhvYt7Qi2ufbFrlN3NdmjK/zqK3FJUxxkYqbVyTKuZ7A1Qr37VJQh7PkjL++RPE6Xt2QwEjeXy7i6m2oXNI+0hOKIpwc6iCwWaBAd47/DdP7lvVNNqKsn96TKUaxaBOImwTiT8ZVo2LbrRvOomncShdJ37FWcprC0/WjwEwe163fGbezNI8J4ZCJCNcI9dOD85vTp/93uQ/JmTNUwJgxA5fHHo9t3LOBlzrgnlw7pBZzfYHxKGHg;20:r+j7SgrcUzgDrGHToVZLz/prFH4LQcCXWGrbyTJZy+9pgA6kV3x0XYYAPQHvc/SqMq4qv9qxAt4S+tR6ldYjvopsR8Z6ZsyTE5HVAdFjNp3D2Sm+iF6IGJXLmt9zzQnlFQnC5UbkCgULcxOvwdiEazyKq3oa0BxsKVIYeG22iTQ= X-MS-Office365-Filtering-Correlation-Id: 867d2538-b90d-4bdb-1c75-08d59dafc52a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(48565401081)(2017052603328)(7193020);SRVR:DM5PR2101MB0920; x-ms-traffictypediagnostic: DM5PR2101MB0920: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(146099531331640); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231221)(944501327)(52105095)(3002001)(10201501046)(6055026)(61426038)(61427038)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(6072148)(201708071742011);SRVR:DM5PR2101MB0920;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB0920; x-forefront-prvs: 0637FCE711 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39860400002)(39380400002)(396003)(366004)(346002)(376002)(199004)(189003)(66066001)(86362001)(59450400001)(3660700001)(3280700002)(25786009)(5890100001)(76176011)(2900100001)(36756003)(6506007)(2906002)(99286004)(86612001)(6486002)(102836004)(305945005)(1076002)(7736002)(575784001)(97736004)(2616005)(446003)(11346002)(476003)(486006)(26005)(6666003)(6512007)(4326008)(107886003)(5660300001)(478600001)(6436002)(105586002)(10290500003)(5250100002)(22452003)(316002)(186003)(8676002)(110136005)(81166006)(54906003)(6116002)(8936002)(72206003)(53936002)(2501003)(3846002)(68736007)(14454004)(81156014)(10090500001)(106356001)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB0920;H:DM5PR2101MB1032.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-microsoft-antispam-message-info: D1P7kFIoZvSK4kw8N9NlxqDoN33B+tvidlfvoHgSwPpNLNdsiwM9gZmTQapkAdBRYHse58b+TiBID7fw4C2FCzWgxZhyyUCZT7hu3kIfAdiqdnBhxODboxSL6shvqTv/uLt6aGX81/ENkRpeeyrQmFzuZQWXff3cPXjcv2T1p61OOmvZrOUT0WiXKh1wE3mye7R6GZaBO+P0RSwLU/pgcCt7eJdE15L6+Mh3dVQ2tZDJkRLFQrk9WSh/AU1xfO6a25o/Le7gv1s38S2OBo56VhmjzTfF6cfeApLWCNyAd0Rhxt3/X22Qublu4bSt/8/k81sWzzI+IetzivY0/W/iTYX98wYS6+yaR9hHFwl65kwb7IyUn7avtWRcKodE+VdHTY33Nb/13vKEzLb6Co5U+s/mJpsjCD2cVJppSaChJ/A= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 867d2538-b90d-4bdb-1c75-08d59dafc52a X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2018 00:18:53.0339 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0920 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Guanglei Li [ Upstream commit 2c0aa08631b86a4678dbc93b9caa5248014b4458 ] Scenario: 1. Port down and do fail over 2. Ap do rds_bind syscall PID: 47039 TASK: ffff89887e2fe640 CPU: 47 COMMAND: "kworker/u:6" #0 [ffff898e35f159f0] machine_kexec at ffffffff8103abf9 #1 [ffff898e35f15a60] crash_kexec at ffffffff810b96e3 #2 [ffff898e35f15b30] oops_end at ffffffff8150f518 #3 [ffff898e35f15b60] no_context at ffffffff8104854c #4 [ffff898e35f15ba0] __bad_area_nosemaphore at ffffffff81048675 #5 [ffff898e35f15bf0] bad_area_nosemaphore at ffffffff810487d3 #6 [ffff898e35f15c00] do_page_fault at ffffffff815120b8 #7 [ffff898e35f15d10] page_fault at ffffffff8150ea95 [exception RIP: unknown or invalid address] RIP: 0000000000000000 RSP: ffff898e35f15dc8 RFLAGS: 00010282 RAX: 00000000fffffffe RBX: ffff889b77f6fc00 RCX:ffffffff81c99d88 RDX: 0000000000000000 RSI: ffff896019ee08e8 RDI:ffff889b77f6fc00 RBP: ffff898e35f15df0 R8: ffff896019ee08c8 R9:0000000000000000 R10: 0000000000000400 R11: 0000000000000000 R12:ffff896019ee08c0 R13: ffff889b77f6fe68 R14: ffffffff81c99d80 R15: ffffffffa022a1e0 ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018 #8 [ffff898e35f15dc8] cma_ndev_work_handler at ffffffffa022a228 [rdma_cm] #9 [ffff898e35f15df8] process_one_work at ffffffff8108a7c6 #10 [ffff898e35f15e58] worker_thread at ffffffff8108bda0 #11 [ffff898e35f15ee8] kthread at ffffffff81090fe6 PID: 45659 TASK: ffff880d313d2500 CPU: 31 COMMAND: "oracle_45659_ap" #0 [ffff881024ccfc98] __schedule at ffffffff8150bac4 #1 [ffff881024ccfd40] schedule at ffffffff8150c2cf #2 [ffff881024ccfd50] __mutex_lock_slowpath at ffffffff8150cee7 #3 [ffff881024ccfdc0] mutex_lock at ffffffff8150cdeb #4 [ffff881024ccfde0] rdma_destroy_id at ffffffffa022a027 [rdma_cm] #5 [ffff881024ccfe10] rds_ib_laddr_check at ffffffffa0357857 [rds_rdma] #6 [ffff881024ccfe50] rds_trans_get_preferred at ffffffffa0324c2a [rds] #7 [ffff881024ccfe80] rds_bind at ffffffffa031d690 [rds] #8 [ffff881024ccfeb0] sys_bind at ffffffff8142a670 PID: 45659 PID: 47039 rds_ib_laddr_check /* create id_priv with a null event_handler */ rdma_create_id rdma_bind_addr cma_acquire_dev /* add id_priv to cma_dev->id_list */ cma_attach_to_dev cma_ndev_work_handler /* event_hanlder is null */ id_priv->id.event_handler Signed-off-by: Guanglei Li Signed-off-by: Honglei Wang Reviewed-by: Junxiao Bi Reviewed-by: Yanjun Zhu Reviewed-by: Leon Romanovsky Acked-by: Santosh Shilimkar Acked-by: Doug Ledford Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/rds/ib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/rds/ib.c b/net/rds/ib.c index 36dd2099048a..04da68e5dbe6 100644 --- a/net/rds/ib.c +++ b/net/rds/ib.c @@ -347,7 +347,8 @@ static int rds_ib_laddr_check(struct net *net, __be32 a= ddr) /* Create a CMA ID and try to bind it. This catches both * IB and iWARP capable NICs. */ - cm_id =3D rdma_create_id(&init_net, NULL, NULL, RDMA_PS_TCP, IB_QPT_RC); + cm_id =3D rdma_create_id(&init_net, rds_rdma_cm_event_handler, + NULL, RDMA_PS_TCP, IB_QPT_RC); if (IS_ERR(cm_id)) return PTR_ERR(cm_id); =20 --=20 2.15.1