From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-4102378-1523247059-2-1554588769460040005 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, MAILING_LIST_MULTI -1, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES endasv, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1523247059; b=ddpbLOTwQ6ry8rrp3D6IV4m+YKir87IkLINVGgOzf9cNOLScaB SjXcKKHN8X2cdhJjmUWjVSXZO/3xxLZIiL6QWDD9HcKrXnatGY2JUP3+i+n4va4d 9/AB3JvO/EE++ooHRm8+yTWNJ5psLeuOjDIGe1B1i6NC505XskGvswxf+LaPQEoc ftBNvzK0I3eLA9oi+0gsYRDBTFgD6zQzUzro357UpPXj+TSovn7EOxp7d6yRJZpC cQBb9/QUvTl0mqSc7JlOLLMuKhRz+FtHsj5oJ1cQzZgUNgdlL+irdCCnSj4rjec8 w8gshLqSL/atuD4L6KLMrHMy+y1yZyCq89AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=fm2; t=1523247059; bh=t3+S5T1SQv bM7HS1mHUAHCUwbYrSy4QelidoN/ffFdA=; b=SVSKUhej2nZLQJJrBId87fBe4j 2NV3c2ywytAW3MarAfGRXNsiM84+JXt2zBSd7gdYr8HL91yjL6SYveqJSb8is8Bi DwG/ntIjGUwx5wTU3fCz70aDX/0QAsEsZ9cgv3AE7KtRCtTv1Kqj9OgGvfsAoj/2 bXKj2EuezbO1p3ymPSQEikHITqzvm2OujwNP3SjJMmEXVZHQvwMt0eIxzVcRKV3M gDGT9CIw+U3yWfZpPOHOgLfwy92MPADDNmFZMhlSSIk2qfhmcrMSTvpuzZ+DjyeI vlXZFf5LFvh1DVRPhrzHI06rWqRm/Sa5gLVGoBpV05SoGO+JLFlEFDoZPTSQ== ARC-Authentication-Results: i=1; mx4.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=J5Z3+P1O x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx4.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=J5Z3+P1O x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfA7nYK6NyT3sTIiKGFTjjJKbGxC83vDmwfxmkWEvgJdiTrQdEVQnxKFXLGXvO9Am42OjuZxN2eAFDPmGRW+TO36kWCW2+xYVsKrsNGy0xAG9wRFOdIm7 6W6I8v06RlWaAwQhf56NVqTrdaM22BglWCgT6rGuoFmkHwDE35HG9qBFqrhjSscmqMxNOY70G7yiTB01lI0wyOl7hVSQ8fK7w8Oq02Czzm+AxRYjtRwCdbhZ X-CM-Analysis: v=2.3 cv=JLoVTfCb c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=wRwT6uffUbIA:10 a=t_PdEiP4ckcA:10 a=mw6kJ3eo-EIA:10 a=8nJEP1OIZ-IA:10 a=xqWC_Br6kY4A:10 a=Kd1tUaAdevIA:10 a=Lf-vpJhqX20A:10 a=yPCof4ZbAAAA:8 a=JDjsHSkAAAAA:8 a=yMhMjlubAAAA:8 a=KSPy7bt753akS31xu34A:9 a=wPNLvfGTeEIA:10 a=dseMxAR1CDlncBZeV_se:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753638AbeDIEKy (ORCPT ); Mon, 9 Apr 2018 00:10:54 -0400 Received: from mail-co1nam03on0101.outbound.protection.outlook.com ([104.47.40.101]:48974 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752996AbeDIARC (ORCPT ); Sun, 8 Apr 2018 20:17:02 -0400 From: Sasha Levin To: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Chuck Lever , Anna Schumaker , Sasha Levin Subject: [PATCH AUTOSEL for 4.15 018/189] xprtrdma: Eliminate unnecessary lock cycle in xprt_rdma_send_request Thread-Topic: [PATCH AUTOSEL for 4.15 018/189] xprtrdma: Eliminate unnecessary lock cycle in xprt_rdma_send_request Thread-Index: AQHTz5gSrWCSqHGLUkS2s/TqYTxTKA== Date: Mon, 9 Apr 2018 00:16:58 +0000 Message-ID: <20180409001637.162453-18-alexander.levin@microsoft.com> References: <20180409001637.162453-1-alexander.levin@microsoft.com> In-Reply-To: <20180409001637.162453-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR2101MB1127;7:SFqyHYm8LNCKZnGiPwoniw7x3jvktniyH4Ryyuepk0tq22am1Vr6LV4JNUrN+msY8Di6RvxqBVDl1aaFZYwkTjjIARJ0L1qbjrVerDnZN4BvA5+X/xf0j+aH50EnpHWVKL1kNAyz98X4eCLVBGWDE3YHlcY8aFrVKHAbQhx2pw1I1Wkr8/M5x3doJoYUx++nFOArhkW4ZRuXF6k5idZzNjtvk7hP2G56h9Uvcg+HE257N0eGvSy6/sMPQJL1SxPW;20:IU4QKFpC22xb8EpcpnypHdgdDO4BIEc9oIOuBvaNvXDa0qP6RBQvt6/LPZ+Numgioyn242Jak38LltFSiRjNTuMDVD6x1M7Z/5il6nKn2nBTkU34AI+eXV6a46sQE1enVjHTdrisd+YIcDTG773E0S5MriCCrS511tH3y/g46Lc= x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant X-MS-Office365-Filtering-Correlation-Id: cdda8afe-5513-4d76-73a1-08d59daf3583 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020);SRVR:DM5PR2101MB1127; x-ms-traffictypediagnostic: DM5PR2101MB1127: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(21532816269658)(146099531331640); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501327)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(61426038)(61427038)(6041310)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:DM5PR2101MB1127;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB1127; x-forefront-prvs: 0637FCE711 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(39380400002)(39860400002)(376002)(346002)(366004)(189003)(199004)(105586002)(186003)(66066001)(6486002)(54906003)(7736002)(26005)(575784001)(86362001)(316002)(305945005)(110136005)(478600001)(3280700002)(86612001)(10290500003)(25786009)(5250100002)(2616005)(99286004)(22452003)(5660300001)(3660700001)(2900100001)(81166006)(3846002)(2906002)(106356001)(6506007)(59450400001)(107886003)(486006)(8676002)(81156014)(14454004)(10090500001)(68736007)(4326008)(6116002)(1076002)(72206003)(102836004)(97736004)(11346002)(8936002)(476003)(2501003)(6436002)(6512007)(446003)(76176011)(36756003)(53936002)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB1127;H:DM5PR2101MB1032.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-microsoft-antispam-message-info: 9Kr+oHxp51za33G0sXRGvTM3pvQrD4Eon3mJPuvufmrhkKwm2lwz4li3hycUglTFeoE7cE+v2WfLkF+JEAqVUMbybZdY5eEqYwOJ5PKc4u6v3zi3nqv8Kcgfh5HglC+dW3IpLMQ0y2kEmizBbq1dMaPxXd9IaZJ5P02xXbqbN/lYeijRqxdVhMdoXUpQ4E4d+L9kVzG2pl5Ij2dFP3IeWHJgag8bqbp9VMsSOmDaNNpXYkz4eI+b8e4ASmXINj0+oTRrmm/xK2ETF6kK+Vc+IcDUKZPNfojn8SNWBrBDMC3WpOgYdTBTUBFtrIZQXugdMUSebu2zrCe4cElJp/zvqSxDcVCeI1yen8ijZwNhH8oszmEQaieCgheH3NnXQcYDz1euCkZnl2ARx+HhhUFlodr7hZydQO4AW0+CeJGzEgY= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: cdda8afe-5513-4d76-73a1-08d59daf3583 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2018 00:16:58.4344 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1127 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Chuck Lever [ Upstream commit 42b9f5c58aa8c59c91ead0254f0c193e3438b020 ] The rpcrdma_req is not shared yet, and its associated Send hasn't been posted, thus RMW should be safe. There's no need for the expense of a lock cycle here. Fixes: 0ba6f37012db ("xprtrdma: Refactor rpcrdma_deferred_completion") Signed-off-by: Chuck Lever Signed-off-by: Anna Schumaker Signed-off-by: Sasha Levin --- net/sunrpc/xprtrdma/transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/xprtrdma/transport.c b/net/sunrpc/xprtrdma/transpor= t.c index 6ee1ad8978f3..76c03aa6cb57 100644 --- a/net/sunrpc/xprtrdma/transport.c +++ b/net/sunrpc/xprtrdma/transport.c @@ -744,7 +744,7 @@ xprt_rdma_send_request(struct rpc_task *task) goto drop_connection; req->rl_connect_cookie =3D xprt->connect_cookie; =20 - set_bit(RPCRDMA_REQ_F_PENDING, &req->rl_flags); + __set_bit(RPCRDMA_REQ_F_PENDING, &req->rl_flags); if (rpcrdma_ep_post(&r_xprt->rx_ia, &r_xprt->rx_ep, req)) goto drop_connection; =20 --=20 2.15.1