From: Andrew Lunn <andrew@lunn.ch>
To: AceLan Kao <acelan.kao@canonical.com>
Cc: Jay Cliburn <jcliburn@gmail.com>,
Chris Snook <chris.snook@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Rakesh Pandit <rakesh@tuxera.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] alx: add disable_wol paramenter
Date: Mon, 9 Apr 2018 14:39:10 +0200 [thread overview]
Message-ID: <20180409123910.GB31060@lunn.ch> (raw)
In-Reply-To: <1523273714-17264-2-git-send-email-acelan.kao@canonical.com>
On Mon, Apr 09, 2018 at 07:35:14PM +0800, AceLan Kao wrote:
> The WoL feature was reported broken and will lead to
> the system resume immediately after suspending.
> This symptom is not happening on every system, so adding
> disable_wol option and disable WoL by default to prevent the issue from
> happening again.
> const char alx_drv_name[] = "alx";
>
> +/* disable WoL by default */
> +bool disable_wol = 1;
> +module_param(disable_wol, bool, 0);
> +MODULE_PARM_DESC(disable_wol, "Disable Wake on Lan feature");
> +
Hi AceLan
This seems like you are papering over the cracks. And module
parameters are not liked.
Please try to find the real problem.
Andrew
next prev parent reply other threads:[~2018-04-09 12:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 11:35 [PATCH 1/2] Revert "alx: remove WoL support" AceLan Kao
2018-04-09 11:35 ` [PATCH 2/2] alx: add disable_wol paramenter AceLan Kao
2018-04-09 12:39 ` Andrew Lunn [this message]
2018-04-09 14:50 ` David Miller
2018-04-10 2:40 ` AceLan Kao
2018-04-24 3:45 ` AceLan Kao
2018-05-09 2:40 ` AceLan Kao
2018-05-09 13:45 ` Andrew Lunn
2018-05-10 5:58 ` AceLan Kao
2018-05-10 12:34 ` Andrew Lunn
2018-05-14 1:55 ` AceLan Kao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180409123910.GB31060@lunn.ch \
--to=andrew@lunn.ch \
--cc=acelan.kao@canonical.com \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=jcliburn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rakesh@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox