From: Ingo Molnar <mingo@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tick-sched: avoid a maybe-uninitialized warning
Date: Mon, 9 Apr 2018 18:18:17 +0200 [thread overview]
Message-ID: <20180409161817.bnmokplnoagyxwrc@gmail.com> (raw)
In-Reply-To: <20180409122339.1709840-1-arnd@arndb.de>
* Arnd Bergmann <arnd@arndb.de> wrote:
> The use of bitfields seems to confuse gcc, leading to a false-positive
> warning in all compiler versions:
>
> kernel/time/tick-sched.c: In function 'tick_nohz_idle_exit':
> kernel/time/tick-sched.c:538:2: error: 'now' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> This introduces a temporary variable to track the flags so gcc
> doesn't have to evaluate twice, eliminating the code path that
> leads to the warning.
>
> Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85301
> Fixes: 1cae544d42d2 ("nohz: Gather tick_sched booleans under a common flag field")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Which tree is this against? There's no such commit either in -tip, upstream or in
-next AFAICS.
Thanks,
Ingo
next prev parent reply other threads:[~2018-04-09 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 12:23 [PATCH] tick-sched: avoid a maybe-uninitialized warning Arnd Bergmann
2018-04-09 16:18 ` Ingo Molnar [this message]
2018-04-09 17:53 ` Arnd Bergmann
2018-04-10 7:16 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180409161817.bnmokplnoagyxwrc@gmail.com \
--to=mingo@kernel.org \
--cc=arnd@arndb.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox