From: Christian Brauner <christian.brauner@getenv.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Christian Brauner <christian.brauner@ubuntu.com>,
gregkh@linuxfoundation.org,
containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, ebiederm@xmission.com,
torvalds@linux-foundation.org, viro@zeniv.linux.org.uk
Subject: Re: [PATCH 4/4 v5 RESEND] selftests: add devpts selftests
Date: Tue, 10 Apr 2018 11:41:36 +0200 [thread overview]
Message-ID: <20180410094136.GA3438@mailbox.org> (raw)
In-Reply-To: <87bmerbe1f.fsf@concordia.ellerman.id.au>
On Tue, Apr 10, 2018 at 07:34:36PM +1000, Michael Ellerman wrote:
> Christian Brauner <christian.brauner@ubuntu.com> writes:
> > On Tue, Apr 10, 2018 at 04:20:44PM +1000, Michael Ellerman wrote:
> >> Christian Brauner <christian.brauner@ubuntu.com> writes:
> >> > diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> >> > index 7442dfb73b7f..dbda89c9d9b9 100644
> >> > --- a/tools/testing/selftests/Makefile
> >> > +++ b/tools/testing/selftests/Makefile
> >> > @@ -7,6 +7,7 @@ TARGETS += cpufreq
> >> > TARGETS += cpu-hotplug
> >> > TARGETS += efivarfs
> >> > TARGETS += exec
> >> > +TARGETS += filesystems
> >> ^ This, and ...
> >>
> >> > diff --git a/tools/testing/selftests/filesystems/Makefile b/tools/testing/selftests/filesystems/Makefile
> >> > index 13a73bf725b5..4e6d09fb166f 100644
> >> > --- a/tools/testing/selftests/filesystems/Makefile
> >> > +++ b/tools/testing/selftests/filesystems/Makefile
> >> > @@ -1,5 +1,5 @@
> >> > # SPDX-License-Identifier: GPL-2.0
> >> > -TEST_PROGS := dnotify_test
> >> > +TEST_PROGS := dnotify_test devpts_pts
> >> ^
> >> this ...
> >>
> >> Have the unfortunate effect of running dnotify_test as part of the
> >> default selftest run.
> >>
> >> dnotify_test boils down to:
> >>
> >> while (1) {
> >> pause();
> >> printf("Got event on fd=%d\n", event_fd);
> >> }
> >>
> >>
> >> ie. an infinite loop :)
> >
> > Hi Michael,
> >
> > Ugh, didn't notice this before. Weird test.
>
> No worries. It looks like it was copied from Documentation where it was
> really just sample code, rather than a test.
>
> >> I'll send a patch to fix it.
> >
> > Excellent, you can likely route it through Greg's tty tree.
>
> I've sent it to the kselftest list as well as Greg, so whoever wants to
> merge it is fine by me.
Perfect, thanks!
Christian
next prev parent reply other threads:[~2018-04-10 9:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 16:55 [PATCH 0/4 v5 RESEND] devpts: handle bind-mounts correctly Christian Brauner
2018-03-13 16:55 ` [PATCH 1/4 v5 RESEND] devpts: hoist out check for DEVPTS_SUPER_MAGIC Christian Brauner
2018-03-13 16:55 ` [PATCH 2/4 v5 RESEND] devpts: resolve devpts bind-mounts Christian Brauner
2018-03-13 16:55 ` [PATCH 3/4 v5 RESEND] devpts: comment devpts_mntget() Christian Brauner
2018-03-13 16:55 ` [PATCH 4/4 v5 RESEND] selftests: add devpts selftests Christian Brauner
2018-04-10 6:20 ` Michael Ellerman
2018-04-10 8:42 ` Christian Brauner
2018-04-10 9:34 ` Michael Ellerman
2018-04-10 9:41 ` Christian Brauner [this message]
2018-03-13 17:32 ` [PATCH 0/4 v5 RESEND] devpts: handle bind-mounts correctly Eric W. Biederman
2018-03-13 17:40 ` Greg KH
2018-03-13 18:02 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410094136.GA3438@mailbox.org \
--to=christian.brauner@getenv.org \
--cc=christian.brauner@ubuntu.com \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox