From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754046AbeDJOaG (ORCPT ); Tue, 10 Apr 2018 10:30:06 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:43614 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753120AbeDJOaE (ORCPT ); Tue, 10 Apr 2018 10:30:04 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 759036014B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [next] wil6210: fix potential null dereference of ndev before null check From: Kalle Valo In-Reply-To: <20180328174027.31551-1-colin.king@canonical.com> References: <20180328174027.31551-1-colin.king@canonical.com> To: Colin Ian King Cc: Maya Erez , linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20180410143003.A40E460AFB@smtp.codeaurora.org> Date: Tue, 10 Apr 2018 14:30:03 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin Ian King wrote: > The pointer ndev is being dereferenced before it is being null checked, > hence there is a potential null pointer deference. Fix this by only > dereferencing ndev after it has been null checked > > Detected by CoverityScan, CID#1467010 ("Dereference before null check") > > Fixes: e00243fab84b ("wil6210: infrastructure for multiple virtual interfaces") > Signed-off-by: Colin Ian King > Reviewed-by: Maya Erez > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. db5a4d5e1073 wil6210: fix potential null dereference of ndev before null check -- https://patchwork.kernel.org/patch/10313705/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches