From: Peter Zijlstra <peterz@infradead.org>
To: Yonghong Song <yhs@fb.com>
Cc: mingo@kernel.org, ast@fb.com, daniel@iogearbox.net,
linux-kernel@vger.kernel.org, x86@kernel.org, kernel-team@fb.com,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86/cpufeature: guard asm_volatile_goto usage with CC_HAVE_ASM_GOTO
Date: Tue, 10 Apr 2018 23:07:16 +0200 [thread overview]
Message-ID: <20180410210716.GI4082@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180410204259.3981586-1-yhs@fb.com>
On Tue, Apr 10, 2018 at 01:42:59PM -0700, Yonghong Song wrote:
> Commit d0266046ad54 ("x86: Remove FAST_FEATURE_TESTS")
> removed X86_FAST_FEATURE_TESTS and make macro static_cpu_has() always
> use __always_inline function _static_cpu_has() funciton.
> The static_cpu_has() uses gcc feature asm_volatile_goto construct,
> which is not supported by clang.
There will be more unconditional asm-goto usage, clang is in the process
of growing asm-goto.
next prev parent reply other threads:[~2018-04-10 21:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 20:42 [PATCH] x86/cpufeature: guard asm_volatile_goto usage with CC_HAVE_ASM_GOTO Yonghong Song
2018-04-10 21:07 ` Peter Zijlstra [this message]
2018-04-10 21:28 ` Alexei Starovoitov
2018-04-13 18:19 ` Peter Zijlstra
2018-04-13 20:42 ` Alexei Starovoitov
2018-04-14 10:11 ` Peter Zijlstra
2018-04-14 20:30 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410210716.GI4082@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox