From: Al Viro <viro@ZenIV.linux.org.uk>
To: Joe Perches <joe@perches.com>
Cc: Kees Cook <keescook@chromium.org>,
Kyle Spiers <ksspiers@google.com>, Jan Kara <jack@suse.cz>,
Arnd Bergmann <arnd@arndb.de>,
David Howells <dhowells@redhat.com>,
Greg KH <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] isofs compress: Remove VLA usage
Date: Wed, 11 Apr 2018 07:39:46 +0100 [thread overview]
Message-ID: <20180411063946.GP30522@ZenIV.linux.org.uk> (raw)
In-Reply-To: <15d2961566261c1b9428402930fd3f994c7f472d.camel@perches.com>
On Tue, Apr 10, 2018 at 11:15:28PM -0700, Joe Perches wrote:
> On Tue, 2018-04-10 at 17:51 -0700, Kees Cook wrote:
> > On Tue, Apr 10, 2018 at 5:33 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> > > On Tue, Apr 10, 2018 at 04:45:32PM -0700, Kyle Spiers wrote:
> > > > As part of the effort to remove VLAs from the kernel[1], this changes
> > > > the allocation of the bhs and pages arrays from being on the stack to being
> > > > kcalloc()ed. This also allows for the removal of the explicit zeroing
> > > > of bhs.
> > > >
> > > > https://lkml.org/lkml/2018/3/7/621
> > >
> > > Do you even bother reading the feedback given to such patches? I'm just
> > > curious,
> >
> > He made a tool mistake (sent v2 again) -- please see v4.
>
> No worries but Kyle didn't just mistakenly resend v2.
> It was a v3 with a different below the dashes changelog.
>
> Kyle, it would be good if next time you were to add a
> listing of changes in each revision below the dashes.
Shit happens...
Al, fully expecting to discover having made something spectacularly bonehead
2 minutes after sending a patch out - happens often enough.
next prev parent reply other threads:[~2018-04-11 6:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 23:45 [PATCH v3] isofs compress: Remove VLA usage Kyle Spiers
2018-04-11 0:33 ` Al Viro
2018-04-11 0:51 ` Kees Cook
2018-04-11 6:15 ` Joe Perches
2018-04-11 6:39 ` Al Viro [this message]
2018-04-11 14:53 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180411063946.GP30522@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=arnd@arndb.de \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=ksspiers@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox