From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Yonghong Song <yhs@fb.com>
Cc: Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
David Miller <davem@davemloft.net>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
acme@kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: bpf: handling non BPF register names in inline assembly with -target bpf
Date: Wed, 11 Apr 2018 16:47:29 -0300 [thread overview]
Message-ID: <20180411194729.GD12166@redhat.com> (raw)
In-Reply-To: <613f0a0d-c433-8f4d-dcc1-c9889deae39e@fb.com>
Em Wed, Apr 11, 2018 at 12:22:37PM -0700, Yonghong Song escreveu:
> Look at test bpf-script-test-kbuild.c, I think you can drop
> uapi/asm/ptrace.h from include file list. This way, you do not need
> __BPF__ in x86/include/asm/asm.h. At the same time, you can
> remove __BPF__ as well.
That's even better, I'll try that approach, that code was done by
someone else, so I ended up not considering looking if removing a
unnecessary header would fix the issue, I'll check and if that works
I'll revert the patch that introduced that ifndef __BPF__.
- Arnaldo
next prev parent reply other threads:[~2018-04-11 19:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 16:37 bpf: handling non BPF register names in inline assembly with -target bpf Yonghong Song
2018-04-11 18:39 ` Arnaldo Carvalho de Melo
2018-04-11 19:22 ` Yonghong Song
2018-04-11 19:47 ` Arnaldo Carvalho de Melo [this message]
2018-04-11 23:17 ` Arnaldo Carvalho de Melo
2018-04-11 23:22 ` Yonghong Song
2018-04-16 6:44 ` [tip:perf/urgent] perf tests bpf: Remove unused ptrace.h include from LLVM test tip-bot for Arnaldo Carvalho de Melo
2018-04-16 6:44 ` [tip:perf/urgent] Revert "x86/asm: Allow again using asm.h when building for the 'bpf' clang target" tip-bot for Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180411194729.GD12166@redhat.com \
--to=acme@redhat.com \
--cc=acme@kernel.org \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox