From: Philipp Rudo <prudo@linux.ibm.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Eric Biederman <ebiederm@xmission.com>,
Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Dave Young <dyoung@redhat.com>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/2] kexec: Remove "weak" annotations from headers
Date: Fri, 13 Apr 2018 11:08:20 +0200 [thread overview]
Message-ID: <20180413110820.662d4879@ThinkPad> (raw)
In-Reply-To: <152355706051.36693.9856090891621551967.stgit@bhelgaas-glaptop.roam.corp.google.com>
Hi Bjorn,
in recent patches AKASHI [1] and I [2] made some changes to the declarations
you are touching and already removed some of the weak statements. The patches
got accepted on linux-next and will (hopefully) be pulled for v4.17. So you
should prepare for some merge conflicts. Nevertheless three weak statements
still remain (arch_kexec_walk_mem & arch_kexec_apply_relocations*) so your
patch still makes totally sense.
Thanks
Philipp
[1] https://lkml.org/lkml/2018/3/6/201
[2] https://lkml.org/lkml/2018/3/21/278
On Thu, 12 Apr 2018 13:23:29 -0500
Bjorn Helgaas <helgaas@kernel.org> wrote:
> "Weak" annotations in header files are error-prone because they make
> every definition weak. Remove them from include/linux/kexec.h.
>
> These were introduced in two separate commits, so this is in two
> patches so they can be easily backported to stable kernels (some of
> them date back to v4.3 and one only goes back to v4.10).
>
> ---
>
> Bjorn Helgaas (2):
> kexec: Remove "weak" from kexec_file function declarations
> kexec: Remove "weak" from arch_kexec_walk_mem() declaration
>
>
> include/linux/kexec.h | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>
next prev parent reply other threads:[~2018-04-13 9:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 18:23 [PATCH v1 0/2] kexec: Remove "weak" annotations from headers Bjorn Helgaas
2018-04-12 18:23 ` [PATCH v1 1/2] kexec: Remove "weak" from kexec_file function declarations Bjorn Helgaas
2018-04-12 18:23 ` [PATCH v1 2/2] kexec: Remove "weak" from arch_kexec_walk_mem() declaration Bjorn Helgaas
2018-04-13 9:08 ` Philipp Rudo [this message]
2018-04-13 9:29 ` [PATCH v1 0/2] kexec: Remove "weak" annotations from headers Baoquan He
2018-04-17 14:07 ` Bjorn Helgaas
2018-04-17 14:21 ` Baoquan He
2018-04-17 14:09 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180413110820.662d4879@ThinkPad \
--to=prudo@linux.ibm.com \
--cc=bauerman@linux.vnet.ibm.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=helgaas@kernel.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox