From: Darren Hart <dvhart@infradead.org>
To: Vadim Pasternak <vadimp@mellanox.com>
Cc: andy.shevchenko@gmail.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, jiri@resnulli.us,
michaelsh@mellanox.com, ivecera@redhat.com
Subject: Re: [PATCH v1 4/7] platform: mellanox: add new ODM system types to mlx-platform
Date: Fri, 13 Apr 2018 09:54:33 -0700 [thread overview]
Message-ID: <20180413165433.GF27560@fury> (raw)
In-Reply-To: <1522144927-56512-5-git-send-email-vadimp@mellanox.com>
On Tue, Mar 27, 2018 at 10:02:04AM +0000, Vadim Pasternak wrote:
> Patch adds new ODM systems, matched according to DMI_BOARD_NAME.
General nit. When writing your messages, please use the imperative (command)
form. Rather than:
"Patch adds" or "It changes" use the same form you use in the subject lines:
"Add new ODM systems", "Fix struct field documentation", etc.
Again, I've been rewriting these, but as a regular contributor, this will help
reduce the overhead of reviewing your patches - good for you, good for me :-)
> The supported ODM Ids are: VMOD0001, VMOD0002, VMOD0003, VMOD0004,
> VMOD0005. It doesn't introduce new systems, but allows to
> ODM companies to set DMI_BOARD_VENDOR and DMI_PRODUCT_NAME on
> their own. It assumes that ODM company can't change DMI_BOARD_NAME.
You said "it assumes that ODM companies can't change DMI_BOARD_NAME". Is that an
assumption, or is that how ODMs work with Mellanox?
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2018-04-13 16:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 10:02 [PATCH v1 0/7] platform/x86: Mellanox add fixes and new features Vadim Pasternak
2018-03-27 10:02 ` [PATCH v1 1/7] platform_data/mlxreg: Document fixes for hotplug device Vadim Pasternak
2018-04-13 16:23 ` Darren Hart
2018-03-27 10:02 ` [PATCH v1 2/7] platform/mellanox: mlxreg-hotplug: Document fixes for hotplug private data Vadim Pasternak
2018-04-13 16:27 ` Darren Hart
2018-03-27 10:02 ` [PATCH v1 3/7] platform/mellanox: mlxreg-hotplug: add extra cycle for hotplug work queue Vadim Pasternak
2018-04-13 16:47 ` Darren Hart
2018-04-13 19:39 ` Vadim Pasternak
2018-03-27 10:02 ` [PATCH v1 4/7] platform: mellanox: add new ODM system types to mlx-platform Vadim Pasternak
2018-04-13 16:54 ` Darren Hart [this message]
2018-04-13 19:53 ` Vadim Pasternak
2018-03-27 10:02 ` [PATCH v1 5/7] platform/x86: mlx-platform: Add LED platform driver activation Vadim Pasternak
2018-03-27 10:02 ` [PATCH v1 6/7] platform/mellanox: Introduce support for Mellanox register access driver Vadim Pasternak
2018-03-27 10:02 ` [PATCH v1 7/7] platform/x86: mlx-platform: Add mlxreg-io platform driver activation Vadim Pasternak
2018-04-13 16:17 ` [PATCH v1 0/7] platform/x86: Mellanox add fixes and new features Darren Hart
2018-05-11 15:28 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180413165433.GF27560@fury \
--to=dvhart@infradead.org \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=michaelsh@mellanox.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox