From: Dominique Martinet <asmadeus@codewreck.org>
To: Chengguang Xu <cgxu519@gmx.com>
Cc: ericvh@gmail.com, rminnich@sandia.gov, lucho@ionkov.net,
v9fs-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [V9fs-developer] [PATCH 2/2] fs/9p: detecting invalid options as much as possible
Date: Mon, 16 Apr 2018 16:56:41 +0900 [thread overview]
Message-ID: <20180416075641.GA16402@nautica> (raw)
In-Reply-To: <1523864909-4337-2-git-send-email-cgxu519@gmx.com>
Chengguang Xu wrote on Mon, Apr 16, 2018:
> default:
> + p9_debug(P9_DEBUG_ERROR,
> + "unrecognized mount option \"%s\" or missing value\n",
> + p);
> continue;
The problem with that is that the same options are passed to the vfs,
net and transport init later on - none of which know the full subset of
valid options to tell what option has been recognized or not.
Unless we do some backward-incompatible breakage of passing all the
net/transport options in its own option (e.g. net=foo:bar:moo) there
unfortunately is no nice way of fixing this now.
(I don't mind the rest of the patches, although I'd say if we hit ENOMEM
there is likely trouble going on so I'm not so sure about hiding it if
there also is an EINVAL, but I don't really care)
--
Dominique Martinet | Asmadeus
next prev parent reply other threads:[~2018-04-16 8:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 7:48 [PATCH 1/2] net/9p: detecting invalid options as much as possible Chengguang Xu
2018-04-16 7:48 ` [PATCH 2/2] fs/9p: " Chengguang Xu
2018-04-16 7:56 ` Dominique Martinet [this message]
2018-04-16 11:37 ` [V9fs-developer] " cgxu519
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416075641.GA16402@nautica \
--to=asmadeus@codewreck.org \
--cc=cgxu519@gmx.com \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=rminnich@sandia.gov \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox