From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752227AbeDPO2t (ORCPT ); Mon, 16 Apr 2018 10:28:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:38252 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799AbeDPO2s (ORCPT ); Mon, 16 Apr 2018 10:28:48 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A672217D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Mon, 16 Apr 2018 11:28:45 -0300 From: Arnaldo Carvalho de Melo To: Alexey Budankov Cc: Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andi Kleen , linux-kernel , linux-perf-users@vger.kernel.org Subject: Re: [PATCH v5 1/3] perf/core: store context switch out type into Perf trace Message-ID: <20180416142845.GA18171@kernel.org> References: <9ff84e83-a0ca-dd82-a6d0-cb951689be74@linux.intel.com> <20180409092603.GY4043@hirez.programming.kicks-ass.net> <17c73937-5fdc-7323-366d-edb2f483b30c@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17c73937-5fdc-7323-366d-edb2f483b30c@linux.intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Apr 16, 2018 at 11:29:03AM +0300, Alexey Budankov escreveu: > Hi Arnaldo, > > On 09.04.2018 12:26, Peter Zijlstra wrote: > > On Mon, Apr 09, 2018 at 10:25:32AM +0300, Alexey Budankov wrote: > >> > >> Store preempting context switch out event into Perf trace as a part of > >> PERF_RECORD_SWITCH[_CPU_WIDE] record. > >> > >> Percentage of preempting and non-preempting context switches help > >> understanding the nature of workloads (CPU or IO bound) that are running > >> on a machine; > >> > >> The event is treated as preemption one when task->state value of the > >> thread being switched out is TASK_RUNNING. Event type encoding is > >> implemented using PERF_RECORD_MISC_SWITCH_OUT_PREEMPT bit; > >> > >> Signed-off-by: Alexey Budankov > > > > Acked-by: Peter Zijlstra (Intel) > > > > Acme, I'm thinking you should route this, since most of the changes are > > actually to the tool. > > This is just to make sure it doesn't sneak out of your attention > in hope the plan is still the same as Peter mentioned above. > > Thanks, > Alexey Applying, rebuilding a kernel with this and testing, - Arnaldo