From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AIpwx4/3JQene48VVnLhpk+XiNITh4e49XXrK7zjSwLvCmP0O7rYp1VVDEHh6yFEv+gYMiMcHNxS ARC-Seal: i=1; a=rsa-sha256; t=1523981177; cv=none; d=google.com; s=arc-20160816; b=ivWiypgk3GPXuDh2JUDya7YqWZp9oKDYBFkADxvPHo1gDwPW/b9Al5uPbIIzdDhGmG DGCBua+d1HktEiWGfzs2Xd8bjjeY98A0VPPNspE8UFDs3Tgp0H3lTMhfgxS3YfodmnpW TjFNfAOTVC6/rniLgJS9XW/hnfTTPpwIioAsz4OrF6ZhiT5yeotImq1sZZY14fPTMVv0 ZRrmHIlxHZrS9c+K7Vl2e5k1FHKyPOxuJO5EbmKvQAqlrPVhZUxlCuOuYJkzhEk0jJ7r mdi/CwuMYjn3rTjhDZJPORlPLQOSamb/rZQH4y/ZKvl5kKhOM4yAkM9ZtalUmHNGoCf3 cH7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=NgChBAWHabVJ7n5uK4b6+DGcsozi+v3S7VxO605YMIM=; b=Ox4z5M8TswJhnzfmO4kGKAcyhPboqtqLILwWN2qhNj8JFDorYYHZCkLlZ4qjTNWiJ7 YB+HomgnTzOpBvEUCDJbp4AoVDj2I2KxKp6U8wa52HkCbRO9SLgi6IkVyVCHOH7iLN63 n7I/tvzThArQyXF4DfgX8G85mfQ4IqNvFQ8XRfRiENiBUNj/2Uz8c7Fd7aR9gZt5uNcw Hd5w380haG4yLDMA+aFK/6h44lwZxVBbK9qPHYSKDJozeWBqCXP8PLEiC9WW0ymhsAGw TbyaKihZ9LyZnmoKr+4CSo2VSYK2rBi5edfDy+qlEwU0S4uPfs0Cz215PwC4IHb7XBZc vjvA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 46.44.180.42 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 46.44.180.42 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , =?UTF-8?q?Michel=20D=C3=A4nzer?= , Alex Deucher Subject: [PATCH 4.14 20/49] radeon: hide pointless #warning when compile testing Date: Tue, 17 Apr 2018 17:58:59 +0200 Message-Id: <20180417155715.984237885@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180417155715.032245882@linuxfoundation.org> References: <20180417155715.032245882@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1598009827562745795?= X-GMAIL-MSGID: =?utf-8?q?1598010087032134287?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Arnd Bergmann commit c02216acf4177c4411d33735c81cad687790fa59 upstream. In randconfig testing, we sometimes get this warning: drivers/gpu/drm/radeon/radeon_object.c: In function 'radeon_bo_create': drivers/gpu/drm/radeon/radeon_object.c:242:2: error: #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance thanks to write-combining [-Werror=cpp] #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance \ This is rather annoying since almost all other code produces no build-time output unless we have found a real bug. We already fixed this in the amdgpu driver in commit 31bb90f1cd08 ("drm/amdgpu: shut up #warning for compile testing") by adding a CONFIG_COMPILE_TEST check last year and agreed to do the same here, but both Michel and I then forgot about it until I came across the issue again now. For stable kernels, as this is one of very few remaining randconfig warnings in 4.14. Cc: stable@vger.kernel.org Link: https://patchwork.kernel.org/patch/9550009/ Signed-off-by: Arnd Bergmann Signed-off-by: Michel Dänzer Signed-off-by: Alex Deucher Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/radeon/radeon_object.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/radeon/radeon_object.c +++ b/drivers/gpu/drm/radeon/radeon_object.c @@ -240,9 +240,10 @@ int radeon_bo_create(struct radeon_devic * may be slow * See https://bugs.freedesktop.org/show_bug.cgi?id=88758 */ - +#ifndef CONFIG_COMPILE_TEST #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance \ thanks to write-combining +#endif if (bo->flags & RADEON_GEM_GTT_WC) DRM_INFO_ONCE("Please enable CONFIG_MTRR and CONFIG_X86_PAT for "