From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AIpwx4+5IzkleN8l4a1QutZb7smBFH3m63h74J2eWqTynKJnC+PfRBDqILfvN/E7sOYKS1xlQ5Pa ARC-Seal: i=1; a=rsa-sha256; t=1523981217; cv=none; d=google.com; s=arc-20160816; b=COcavFZTl1HyFLVwBhbb3a45Mfmh53yI8ql0vddvCmO2hgoQaa8gA13RSmlEbJrKzH xEa8P+jMKV3u+KoThY7ttVKnbPMXrLrB367RPzntRwvdLasGNyd0EQOuTLFZOQcw+WRW +VPM77uvP9iafxCKzJP56tEtVGPsPsd2YtW66/tymAFa/W+JUtQv7UGaKWcLlaoL/BR/ p/axG6CHGOX/KGT0QAl/hw5JUD+MJP51Uwi/zGEKRDbZEJVmDig2b9F0/fKGu9oqz1Tr d5DHfcF/IOhZ2wZIduWgFRXrNLJBmJvfdhx2snUiZfpJaGN65kb1PD4BEjwmbd156X4B B9mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=Czv2eGdqcBcNKYJnfFQzL8prJO7U8FJsae16ATqjet4=; b=inv+ejUvErHFpSsptPYoR306Vi/VBMjCHEj9fvPlMQVM868xK8t74TjikAq/qa1YZH /AmRK3Ynyr5VPvwV6X09u/eOw86fbs2MFNAgipfH8LSH3dVQheItFhk40EKg2mGc8kuT leYHDeq8gyjxylw62jXgcLhoQhBk5lDtej9ko1UgIYh+xzOfbLnlzQSQCIEWAPK0oiU+ OajdDXrdsTgKEHEM1jfWdbvppbDmP5BGqEs8ca3BXmURlKvYNFq849ElWnhSK8keY0gQ 3sG1B99lgR7p6oI19xOB/UtM+c8K34m7aKaBs2VPHO83uvR0cKAPW1OtXF86raBQ2ges 16hw== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 46.44.180.42 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 46.44.180.42 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sudhir Sreedharan , Kalle Valo Subject: [PATCH 4.14 35/49] rtl8187: Fix NULL pointer dereference in priv->conf_mutex Date: Tue, 17 Apr 2018 17:59:14 +0200 Message-Id: <20180417155716.690278125@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180417155715.032245882@linuxfoundation.org> References: <20180417155715.032245882@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1598009886651691074?= X-GMAIL-MSGID: =?utf-8?q?1598010128856481538?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sudhir Sreedharan commit 7972326a26b5bf8dc2adac575c4e03ee7e9d193a upstream. This can be reproduced by bind/unbind the driver multiple times in AM3517 board. Analysis revealed that rtl8187_start() was invoked before probe finishes(ie. before the mutex is initialized). INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. CPU: 0 PID: 821 Comm: wpa_supplicant Not tainted 4.9.80-dirty #250 Hardware name: Generic AM3517 (Flattened Device Tree) [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (register_lock_class+0x4f4/0x55c) [] (register_lock_class) from [] (__lock_acquire+0x74/0x1938) [] (__lock_acquire) from [] (lock_acquire+0xfc/0x23c) [] (lock_acquire) from [] (mutex_lock_nested+0x50/0x3b0) [] (mutex_lock_nested) from [] (rtl8187_start+0x2c/0xd54) [] (rtl8187_start) from [] (drv_start+0xa8/0x320) [] (drv_start) from [] (ieee80211_do_open+0x2bc/0x8e4) [] (ieee80211_do_open) from [] (__dev_open+0xb8/0x120) [] (__dev_open) from [] (__dev_change_flags+0x88/0x14c) [] (__dev_change_flags) from [] (dev_change_flags+0x18/0x48) [] (dev_change_flags) from [] (devinet_ioctl+0x738/0x840) [] (devinet_ioctl) from [] (sock_ioctl+0x164/0x2f4) [] (sock_ioctl) from [] (do_vfs_ioctl+0x8c/0x9d0) [] (do_vfs_ioctl) from [] (SyS_ioctl+0x6c/0x7c) [] (SyS_ioctl) from [] (ret_fast_syscall+0x0/0x1c) Unable to handle kernel NULL pointer dereference at virtual address 00000000 pgd = cd1ec000 [00000000] *pgd=8d1de831, *pte=00000000, *ppte=00000000 Internal error: Oops: 817 [#1] PREEMPT ARM Modules linked in: CPU: 0 PID: 821 Comm: wpa_supplicant Not tainted 4.9.80-dirty #250 Hardware name: Generic AM3517 (Flattened Device Tree) task: ce73eec0 task.stack: cd1ea000 PC is at mutex_lock_nested+0xe8/0x3b0 LR is at mutex_lock_nested+0xd0/0x3b0 Cc: stable@vger.kernel.org Signed-off-by: Sudhir Sreedharan Signed-off-by: Kalle Valo Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c +++ b/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c @@ -1450,6 +1450,7 @@ static int rtl8187_probe(struct usb_inte goto err_free_dev; } mutex_init(&priv->io_mutex); + mutex_init(&priv->conf_mutex); SET_IEEE80211_DEV(dev, &intf->dev); usb_set_intfdata(intf, dev); @@ -1625,7 +1626,6 @@ static int rtl8187_probe(struct usb_inte printk(KERN_ERR "rtl8187: Cannot register device\n"); goto err_free_dmabuf; } - mutex_init(&priv->conf_mutex); skb_queue_head_init(&priv->b_tx_status.queue); wiphy_info(dev->wiphy, "hwaddr %pM, %s V%d + %s, rfkill mask %d\n",