From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AIpwx48QcUqL+3CoEexEgwQ7HgxdM08/j4Hy5ANe/bvQyqN5Wqf/HOjiFFNqncEUPFPJSKZukFAV ARC-Seal: i=1; a=rsa-sha256; t=1523981231; cv=none; d=google.com; s=arc-20160816; b=JQWPBaPQEDsJ+fA00/PjQJNPwYYjYMFTi0V0cgRaxZN43f81CpJ5Eg2/b4+MMzrNXg zC9VTpvXqVkRXdlJmSwmYL4m5wLchbygTy3DrUNDnVg8RET2mDmDOVSkjwuqAaL1gUXI qNuxDbKMspP64wht0YS3meEXCcg+urI15xpmBc1trdLukUHlXSlzXKnd18sm5jtpDbx2 u34igJLbx14PWjY45T696Qud2+7J3huhlS8C0yLJEjdPI1mq/GnPxyqVsENnceFzcqWY bnH6Q/gM0XFuNBf45l/5sTdYDYbrxRtKB+W+rpxHaQarytorajeX3jsDKy94l1xPQ6dw 8B4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=chA+mxwY2dPohzlqG5bt9BhbqKIOE1R6qUR7c/3t5Uk=; b=a/ASijLawHwa7eyBgKfMwJf7Z+rutkW10AL52KImv+WandKsEzOTxlDHBdjQboqAMS eaXA7fLvXLryVqdRX5KrFNrOutiu9k+df3BGW6WszhsUiGgwXUm22eD+b4p//n+vl8/n cVnQ9JlJ3uIY6YtvpBIpgk96ElSVwgyhPbOwQx9QcBQBvcRz2/ZGSLForoVeSIdtuxpf DSNb3E4myJInrRYpPoc4d8jlT5MxQz0z0iruuZlh+wTE5i70WYD8qsmaQD3NI3EBUIC2 mMVeGKWpG5YTLpBcYQt0QoStknJbqJ1MmElx3mNX3rSvJj1OaID3rZTvE0kWbFymStt2 FFtw== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 46.44.180.42 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 46.44.180.42 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marek Szyprowski , Guenter Roeck Subject: [PATCH 4.14 40/49] hwmon: (ina2xx) Fix access to uninitialized mutex Date: Tue, 17 Apr 2018 17:59:19 +0200 Message-Id: <20180417155716.941997264@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180417155715.032245882@linuxfoundation.org> References: <20180417155715.032245882@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1598009936138504780?= X-GMAIL-MSGID: =?utf-8?q?1598010143716477122?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Marek Szyprowski commit 0c4c5860e9983eb3da7a3d73ca987643c3ed034b upstream. Initialize data->config_lock mutex before it is used by the driver code. This fixes following warning on Odroid XU3 boards: INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. CPU: 5 PID: 1 Comm: swapper/0 Not tainted 4.15.0-rc7-next-20180115-00001-gb75575dee3f2 #107 Hardware name: SAMSUNG EXYNOS (Flattened Device Tree) [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (dump_stack+0x90/0xc8) [] (dump_stack) from [] (register_lock_class+0x1c0/0x59c) [] (register_lock_class) from [] (__lock_acquire+0x78/0x1850) [] (__lock_acquire) from [] (lock_acquire+0xc8/0x2b8) [] (lock_acquire) from [] (__mutex_lock+0x60/0xa0c) [] (__mutex_lock) from [] (mutex_lock_nested+0x1c/0x24) [] (mutex_lock_nested) from [] (ina2xx_set_shunt+0x70/0xb0) [] (ina2xx_set_shunt) from [] (ina2xx_probe+0x88/0x1b0) [] (ina2xx_probe) from [] (i2c_device_probe+0x1e0/0x2d0) [] (i2c_device_probe) from [] (driver_probe_device+0x2b8/0x4a0) [] (driver_probe_device) from [] (__driver_attach+0xfc/0x120) [] (__driver_attach) from [] (bus_for_each_dev+0x58/0x7c) [] (bus_for_each_dev) from [] (bus_add_driver+0x174/0x250) [] (bus_add_driver) from [] (driver_register+0x78/0xf4) [] (driver_register) from [] (i2c_register_driver+0x38/0xa8) [] (i2c_register_driver) from [] (do_one_initcall+0x48/0x18c) [] (do_one_initcall) from [] (kernel_init_freeable+0x110/0x1d4) [] (kernel_init_freeable) from [] (kernel_init+0x8/0x114) [] (kernel_init) from [] (ret_from_fork+0x14/0x20) Fixes: 5d389b125186 ("hwmon: (ina2xx) Make calibration register value fixed") Signed-off-by: Marek Szyprowski Signed-off-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- drivers/hwmon/ina2xx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/hwmon/ina2xx.c +++ b/drivers/hwmon/ina2xx.c @@ -454,6 +454,7 @@ static int ina2xx_probe(struct i2c_clien /* set the device type */ data->config = &ina2xx_config[chip]; + mutex_init(&data->config_lock); if (of_property_read_u32(dev->of_node, "shunt-resistor", &val) < 0) { struct ina2xx_platform_data *pdata = dev_get_platdata(dev); @@ -480,8 +481,6 @@ static int ina2xx_probe(struct i2c_clien return -ENODEV; } - mutex_init(&data->config_lock); - data->groups[group++] = &ina2xx_group; if (id->driver_data == ina226) data->groups[group++] = &ina226_group;