From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AIpwx48tkNBcq0pC343cz8uF5y01YmynAJxw5zLoOkGiCskI6Uz3P29ShvjS355N82mGVUXsrjpk ARC-Seal: i=1; a=rsa-sha256; t=1523980983; cv=none; d=google.com; s=arc-20160816; b=upVHxdJsvn/qrrQqosXY6/+JRUavlCEwOb3hvpe8SkQhwLGSBFpC2MJ2BX3QDwQ/KR Joy8Ttk3o/xF3w0rgYh6MNOAdOu2Dfx4rq+ZPKrutiXKaIH/d20qaor8iXb4TGnX/LVp 1VkNsr1HZD9NhfDp+Oa8xpw4LFBZ3OEi+fzI6WQFzrurhe/cz9hNxUHliwHmauODaoig p9Ueo35e8QczfQ85L6Sao4KlArsUubivvEKXUDBFo5mYzzvx+G4THS1N698XaxJay/4q tCr/4myzi8acE5tCgafGJenwy1XKv+RGyfk10W2stFeuL7lY4GGoVGlEYKhSg1Gh02es joFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=idcHsiUh3nhGs48nAZIjjifPSI1diMRcMa3c4DynOh0=; b=vMXLxPIYFcdgSXbM+wyRpS/VcUQKmEW4CKBjrwNgJV7QEcPt7q3ZPoav+kAo44PyO/ jzSApRDdIzZFaoN3+FjF3vRfQy6YhzIaF6bfFHX/nGfGd6OChMIQXyj8kTu+L+Corkp9 nNdmgqX0Rda7JHVb2G+nnDhK/P36H+Vc1rkhCd3rCIsDhkewsF11gtd7RL7mMv+0Y1Fi 1RHxuwqPgh8WDfKa3g74R7mSaf59ZJV2tUk828/vyGh9ZK9qMc4PEPtRgGHfAF8kAXgW NDsKJUYzGhuwqLo48mZVf1M6YFPEvwEFr1mYnkprqPrH8A6PnIj0HIx3Iqveh4N8Gnzq 8iyA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 46.44.180.42 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 46.44.180.42 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans de Goede , Marcel Holtmann Subject: [PATCH 4.16 67/68] Bluetooth: hci_bcm: Treat Interrupt ACPI resources as always being active-low Date: Tue, 17 Apr 2018 17:58:20 +0200 Message-Id: <20180417155752.059464979@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180417155749.341779147@linuxfoundation.org> References: <20180417155749.341779147@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1598009883606736978?= X-GMAIL-MSGID: =?utf-8?q?1598009883606736978?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hans de Goede commit bb5208b314c5127b716b2ee4f55803a8bb73b750 upstream. Older devices with a serdev attached bcm bt hci, use an Interrupt ACPI resource to describe the IRQ (rather then a GpioInt resource). These device seem to all claim the IRQ is active-high and seem to all need a DMI quirk to treat it as active-low. Instead simply always assume that Interrupt resource specified IRQs are always active-low. This fixes the bt device not being able to wake the host from runtime- suspend on the: Asus T100TAM, Asus T200TA, Lenovo Yoga2 and the Toshiba Encore, without the need to add 4 new DMI quirks for these models. This also allows us to remove 2 DMI quirks for the Asus T100TA and Asus T100CHI series. Likely the 2 remaining quirks can also be removed but I could not find a DSDT of these devices to verify this. Cc: stable@vger.kernel.org Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=198953 Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1554835 Signed-off-by: Hans de Goede Signed-off-by: Marcel Holtmann Signed-off-by: Greg Kroah-Hartman --- drivers/bluetooth/hci_bcm.c | 20 +++----------------- 1 file changed, 3 insertions(+), 17 deletions(-) --- a/drivers/bluetooth/hci_bcm.c +++ b/drivers/bluetooth/hci_bcm.c @@ -795,22 +795,6 @@ static const struct acpi_gpio_mapping ac #ifdef CONFIG_ACPI /* IRQ polarity of some chipsets are not defined correctly in ACPI table. */ static const struct dmi_system_id bcm_active_low_irq_dmi_table[] = { - { - .ident = "Asus T100TA", - .matches = { - DMI_EXACT_MATCH(DMI_SYS_VENDOR, - "ASUSTeK COMPUTER INC."), - DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100TA"), - }, - }, - { - .ident = "Asus T100CHI", - .matches = { - DMI_EXACT_MATCH(DMI_SYS_VENDOR, - "ASUSTeK COMPUTER INC."), - DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100CHI"), - }, - }, { /* Handle ThinkPad 8 tablets with BCM2E55 chipset ACPI ID */ .ident = "Lenovo ThinkPad 8", .matches = { @@ -838,7 +822,9 @@ static int bcm_resource(struct acpi_reso switch (ares->type) { case ACPI_RESOURCE_TYPE_EXTENDED_IRQ: irq = &ares->data.extended_irq; - dev->irq_active_low = irq->polarity == ACPI_ACTIVE_LOW; + if (irq->polarity != ACPI_ACTIVE_LOW) + dev_info(dev->dev, "ACPI Interrupt resource is active-high, this is usually wrong, treating the IRQ as active-low\n"); + dev->irq_active_low = true; break; case ACPI_RESOURCE_TYPE_GPIO: