From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752713AbeDQSNI (ORCPT ); Tue, 17 Apr 2018 14:13:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:42620 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751836AbeDQSNH (ORCPT ); Tue, 17 Apr 2018 14:13:07 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0FB221789 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Tue, 17 Apr 2018 15:13:04 -0300 From: Arnaldo Carvalho de Melo To: Dominik Brodowski Cc: Steven Rostedt , LKML , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , x86@kernel.org Subject: Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names Message-ID: <20180417181304.GA2895@kernel.org> References: <20180417130702.01575029@gandalf.local.home> <20180417172236.GA17342@light.dominikbrodowski.net> <20180417180430.GF3625@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180417180430.GF3625@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Apr 17, 2018 at 03:04:30PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Apr 17, 2018 at 07:22:36PM +0200, Dominik Brodowski escreveu: > > > Added back original compare to not miss 32bit kernel syscalls > > > > s/32bit/32bit and 0-parameter syscalls. > > So this should have covered 0-parameter syscalls, ok, I'm double > checking that the last patch is the one I have running... Because > 0-parameter syscalls are not working for me, i.e. no > syscalls:sys_enter_getppid, for instance. Yeah, failing: [root@jouet ~]# strace -e openat -e file perf test -F -v "mmap interface" |& grep syscalls openat(AT_FDCWD, "/sys/kernel/debug/tracing/events/syscalls/sys_enter_getsid/format", O_RDONLY) = 3 openat(AT_FDCWD, "/sys/kernel/debug/tracing/events/syscalls/sys_enter_getppid/format", O_RDONLY) = -1 ENOENT (No such file or directory) [root@jouet ~]# [root@jouet ~]# ls -la /sys/kernel/debug/tracing/events/syscalls/sys_enter_getppid/format ls: cannot access '/sys/kernel/debug/tracing/events/syscalls/sys_enter_getppid/format': No such file or directory [root@jouet ~]# With: +#define ARCH_HAS_SYSCALL_MATCH_SYM_NAME +static inline bool arch_syscall_match_sym_name(const char *sym, const char *name) +{ + /* + * Compare the symbol name with the system call name. Skip the + * "__x64_sys" prefix. + */ + return !strcmp(sym + 9, name + 3) || !strcmp(sym + 3, name + 3); +} in place. - Arnaldo