From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753549AbeDRCRs (ORCPT ); Tue, 17 Apr 2018 22:17:48 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:44596 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752679AbeDRCRr (ORCPT ); Tue, 17 Apr 2018 22:17:47 -0400 X-Google-Smtp-Source: AIpwx4/KljcUUFSwVKitHpWaPXKtFLaSUFQfuwGwdfi7sfXlrDSUCGKMLZ+HoFB5JzfMoNdYsCyorA== Date: Tue, 17 Apr 2018 20:17:41 -0600 From: Jason Gunthorpe To: Geert Uytterhoeven Cc: Doug Ledford , Matan Barak , Andrew Morton , Arnd Bergmann , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] IB/uverbs: Add missing braces in anonymous union initializers Message-ID: <20180418021741.GA24191@ziepe.ca> References: <1523285567-26270-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1523285567-26270-1-git-send-email-geert@linux-m68k.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 09, 2018 at 04:52:47PM +0200, Geert Uytterhoeven wrote: > With gcc-4.1.2: > > drivers/infiniband/core/uverbs_std_types_flow_action.c:366: error: unknown field ‘ptr’ specified in initializer > drivers/infiniband/core/uverbs_std_types_flow_action.c:367: error: unknown field ‘type’ specified in initializer > drivers/infiniband/core/uverbs_std_types_flow_action.c:367: warning: missing braces around initializer > drivers/infiniband/core/uverbs_std_types_flow_action.c:367: warning: (near initialization for ‘uverbs_flow_action_esp_keymat[0]..’) > drivers/infiniband/core/uverbs_std_types_flow_action.c:368: error: unknown field ‘min_len’ specified in initializer > drivers/infiniband/core/uverbs_std_types_flow_action.c:368: warning: excess elements in union initializer > drivers/infiniband/core/uverbs_std_types_flow_action.c:368: warning: (near initialization for ‘uverbs_flow_action_esp_keymat[0].’) > drivers/infiniband/core/uverbs_std_types_flow_action.c:368: error: unknown field ‘len’ specified in initializer > drivers/infiniband/core/uverbs_std_types_flow_action.c:368: warning: excess elements in union initializer > drivers/infiniband/core/uverbs_std_types_flow_action.c:368: warning: (near initialization for ‘uverbs_flow_action_esp_keymat[0].’) > drivers/infiniband/core/uverbs_std_types_flow_action.c:369: error: unknown field ‘flags’ specified in initializer > drivers/infiniband/core/uverbs_std_types_flow_action.c:369: warning: excess elements in union initializer > drivers/infiniband/core/uverbs_std_types_flow_action.c:369: warning: (near initialization for ‘uverbs_flow_action_esp_keymat[0].’) > drivers/infiniband/core/uverbs_std_types_flow_action.c:376: error: unknown field ‘ptr’ specified in initializer > drivers/infiniband/core/uverbs_std_types_flow_action.c:377: error: unknown field ‘type’ specified in initializer > drivers/infiniband/core/uverbs_std_types_flow_action.c:377: warning: missing braces around initializer > drivers/infiniband/core/uverbs_std_types_flow_action.c:377: warning: (near initialization for ‘uverbs_flow_action_esp_replay[0]..’) > drivers/infiniband/core/uverbs_std_types_flow_action.c:379: error: unknown field ‘len’ specified in initializer > drivers/infiniband/core/uverbs_std_types_flow_action.c:379: warning: excess elements in union initializer > drivers/infiniband/core/uverbs_std_types_flow_action.c:379: warning: (near initialization for ‘uverbs_flow_action_esp_replay[0].’) > drivers/infiniband/core/uverbs_std_types_flow_action.c:383: error: unknown field ‘ptr’ specified in initializer > drivers/infiniband/core/uverbs_std_types_flow_action.c:384: error: unknown field ‘type’ specified in initializer > drivers/infiniband/core/uverbs_std_types_flow_action.c:385: error: unknown field ‘min_len’ specified in initializer > drivers/infiniband/core/uverbs_std_types_flow_action.c:385: warning: excess elements in union initializer > drivers/infiniband/core/uverbs_std_types_flow_action.c:385: warning: (near initialization for ‘uverbs_flow_action_esp_replay[1].’) > drivers/infiniband/core/uverbs_std_types_flow_action.c:385: error: unknown field ‘len’ specified in initializer > drivers/infiniband/core/uverbs_std_types_flow_action.c:385: warning: excess elements in union initializer > drivers/infiniband/core/uverbs_std_types_flow_action.c:385: warning: (near initialization for ‘uverbs_flow_action_esp_replay[1].’) > drivers/infiniband/core/uverbs_std_types_flow_action.c:386: error: unknown field ‘flags’ specified in initializer > drivers/infiniband/core/uverbs_std_types_flow_action.c:386: warning: excess elements in union initializer > drivers/infiniband/core/uverbs_std_types_flow_action.c:386: warning: (near initialization for ‘uverbs_flow_action_esp_replay[1].’) > > Add the missing braces to fix this. > > Signed-off-by: Geert Uytterhoeven > --- > Presumably also needed for Andrew's gcc-4.4.4. > > Unfortunately I don't know how to fix the remaining warnings: > > drivers/infiniband/core/uverbs_std_types_flow_action.c:391: warning: initialization from incompatible pointer type > drivers/infiniband/core/uverbs_std_types_flow_action.c:408: warning: initialization from incompatible pointer type > drivers/infiniband/core/uverbs_std_types_flow_action.c:423: warning: initialization from incompatible pointer type > drivers/infiniband/core/uverbs_std_types_flow_action.c:430: warning: initialization from incompatible pointer type > drivers/infiniband/core/uverbs_std_types_cq.c:149: warning: initialization from incompatible pointer type > drivers/infiniband/core/uverbs_std_types_cq.c:194: warning: initialization from incompatible pointer type > drivers/infiniband/core/uverbs_std_types_cq.c:202: warning: initialization from incompatible pointer type > drivers/infiniband/core/uverbs_std_types_dm.c:86: warning: initialization from incompatible pointer type > drivers/infiniband/core/uverbs_std_types_dm.c:97: warning: initialization from incompatible pointer type > drivers/infiniband/core/uverbs_std_types_dm.c:104: warning: initialization from incompatible pointer type > drivers/infiniband/core/uverbs_std_types_mr.c:118: warning: initialization from incompatible pointer type > drivers/infiniband/core/uverbs_std_types_mr.c:144: warning: initialization from incompatible pointer type > > Smallest variable declaration exposing the problem: > > static const struct uverbs_method_def bad = { > .attrs = &(const struct uverbs_attr_def * const []) { } > }; > --- > drivers/infiniband/core/uverbs_std_types_flow_action.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) I've applied this to for-rc, thanks I have a notion on how to fix the warnings, maybe you will see that in 4.18.. Jason